TestJobHistoryVersion should not create directory in current dir.

• Key: HADOOP-4632
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Amar Kamat
• Reporter: Amareshwari Sriramadasu
• Affects Version/s: 0.19.0
• Fix Version/s: 0.19.1

Description

TestJobHistoryVersion creates a directory, test-history-version, in the current dierctory. It should be created in test.build.data directory.

Comments

[Amar Kamat]

Attaching a patch the fixes the issue. Manually tested the patch.

[Amareshwari Sriramadasu]

The default TEST_DIR should not be /test-history-version, it can be inside /tmp.

[Amar Kamat]

Attaching a new patch incorporating Amareshwari's comments.

[Amareshwari Sriramadasu]

+1

[Hadoop QA]

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12393786/HADOOP-4632-v1.1.patch
against trunk revision 713612.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 4 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3582/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3582/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3582/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3582/console

This message is automatically generated.

[Chris Douglas]

test.build.data is shared by all the other unit tests; it shouldn't be the base for scratchwork.

new Path(System.getProperty("test.build.data", "/tmp"), "testname")

Is the normal idiom. The test directory should also be deleted when the tests have completed.

[Amar Kamat]

Attaching a new patch with the changes.

[Amareshwari Sriramadasu]

+1 Patch looks good.

[Chris Douglas]

I just committed this. Thanks, Amar

[Hudson]

Integrated in Hadoop-trunk #680 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/680/)