[#HADOOP-4626] API link in forrest doc should point to the same version of hadoop.

Hadoop Common

API link in forrest doc should point to the same version of hadoop.

Created: 10/Nov/08 07:14 PM Updated: 27/May/09 10:07 PM

Return to search

Component/s:

documentation

Affects Version/s:

0.17.2

Fix Version/s:

0.20.1, 0.21.0

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	4626_20090526.patch	2009-05-26 10:16 PM	Tsz Wo (Nicholas), SZE	2 kB

Issue Links:

Reference

This issue is related to:

HDFS-491 Broken link in Safemode documentation

Hadoop Flags:	Reviewed
Resolution Date:	27/May/09 10:07 PM

Description

« Hide

For example, in http://hadoop.apache.org/core/docs/r0.17.2/hdfs_user_guide.html, the setSafeMode() link is pointing to http ://hadoop.apache.org/core/docs/current/..., which is not an 0.17 doc.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Doug Cutting added a comment - 10/Nov/08 07:46 PM

These should be replaced in the xml source with relative links to api/org/apache/hadoop/...

[ Permlink | « Hide ]

Tsz Wo (Nicholas), SZE added a comment - 20/Feb/09 08:07 PM - edited

The setSafeMode() link indeed is a missing link, instead of a broken link, since the hdfs api docs are not available in the public web site. Similarly, links to HDFS Java API do not exist.

[ Permlink | « Hide ]

Tsz Wo (Nicholas), SZE added a comment - 26/May/09 10:16 PM

4626_20090526.patch: fix API version.

The setSafeMode() link will be fixed in HADOOP-5918.

[ Permlink | « Hide ]

Tsz Wo (Nicholas), SZE added a comment - 27/May/09 02:43 PM

     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no tests are needed for this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.

This is a documentation change. No sure why "ant test-patch" cannot detect it but -1 on tests included.

[ Permlink | « Hide ]

Tsz Wo (Nicholas), SZE added a comment - 27/May/09 02:48 PM

I checked the generated doc manually. The links are correct.

[ Permlink | « Hide ]

Ravi Phulari added a comment - 27/May/09 09:57 PM

+1
Generated doc manually and verified for link correctness. Patch looks good.
Thanks Nicholas.

[ Permlink | « Hide ]

Tsz Wo (Nicholas), SZE added a comment - 27/May/09 10:07 PM

I have committed this to 0.20 and above.