Examples -Driver does not check first argument.

• Key: HADOOP-4608
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Edward J. Yoon
• Reporter: Edward J. Yoon
• Affects Version/s: 0.18.2
• Fix Version/s: 0.20.0

Description

hadoop@vldb ~/hadoop $ bin/hadoop jar hadoop-0.18.2-examples.jar
An example program must be given as the first argument.
Valid program names are:
aggregatewordcount: An Aggregate based map/reduce program that counts the words in the input files.
aggregatewordhist: An Aggregate based map/reduce program that computes the histogram of the words in the input files.
grep: A map/reduce program that counts the matches of a regex in the input.
join: A job that effects a join over sorted, equally partitioned datasets
multifilewc: A job that counts words from several files.
pentomino: A map/reduce tile laying program to find solutions to pentomino problems.
pi: A map/reduce program that estimates Pi using monte-carlo method.
randomtextwriter: A map/reduce program that writes 10GB of random textual data per node.
randomwriter: A map/reduce program that writes 10GB of random data per node.
sleep: A job that sleeps at each map and reduce task.
sort: A map/reduce program that sorts the data written by the random writer.
sudoku: A sudoku solver.
wordcount: A map/reduce program that counts the words in the input files.
java.lang.IllegalArgumentException: An example program must be given as the first argument.
at org.apache.hadoop.util.ProgramDriver.driver(ProgramDriver.java:123)
at org.apache.hadoop.examples.ExampleDriver.main(ExampleDriver.java:54)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.hadoop.util.RunJar.main(RunJar.java:155)
at org.apache.hadoop.mapred.JobShell.run(JobShell.java:54)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:65)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:79)
at org.apache.hadoop.mapred.JobShell.main(JobShell.java:68)

Comments

[Edward J. Yoon]

IMO, In this case the exit is enough.

[Edward J. Yoon]

Current trunk also affected.

[Edward J. Yoon]

Submit my patch. Can anyone review my code? Thanks in advance.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12393602/HADOOP-4608.patch
against trunk revision 712344.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

-1 javadoc. The javadoc tool appears to have generated 1 warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

-1 findbugs. The patch appears to introduce 1 new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3566/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3566/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3566/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3566/console

This message is automatically generated.

[Owen O'Malley]

I just committed this. Thanks, Edward!

This isn't a blocker, so only applying to trunk.

[Hudson]

Integrated in Hadoop-trunk #661 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/661/)
. Don't print a stack trace when the example driver gets an
unknown program to run. (Edward Yoon via omalley)