INode and its sub-classes should be package private

• Key: HADOOP-4572
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Tsz Wo (Nicholas), SZE
• Reporter: Tsz Wo (Nicholas), SZE
• Fix Version/s: 0.20.0

Description

INode, INodeFile, INodeDirectory and INodeFileUnderConstruction should be changed from public to package private. As a consequence, some test classes like CreateEditsLog have to be moved to org.apache.hadoop.hdfs.server.namenode.

Comments

[Tsz Wo (Nicholas), SZE]

4572_20081103.patch:

• changed INode, INodeFile, INodeDirectory and INodeFileUnderConstruction to package private.
• moved TestNNThroughputBenchmark, FileNameGenerator, CreateEditsLog and NNThroughputBenchmark to org.apache.hadoop.hdfs.server.namenode.

[Konstantin Shvachko]

+1 This looks good.

[Hadoop QA]

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12393273/4572_20081103.patch
against trunk revision 711482.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 24 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/console

This message is automatically generated.

[Tsz Wo (Nicholas), SZE]

svn_move.sh: a script for moving the source files.

[Tsz Wo (Nicholas), SZE]

I just committed this.

[Hudson]

Integrated in Hadoop-trunk #653 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/653/)
. Change INode and its sub-classes to package private. (szetszwo)