Metric Averages are not averages

• Key: HADOOP-4369
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Blocker
• Assignee: Brian Bockelman
• Reporter: Brian Bockelman
• Component/s: metrics
• Affects Version/s: 0.18.1
• Fix Version/s: 0.18.2

Description

Metrics averages are not averages; instead of updating the metric with the average number periodically, Hadoop metrics increments the metric.

I.e., each update we have value = old_value + current average. Instead, we want each update to have value = current_average.

Patch will be attached momentarily.

Comments

[Brian Bockelman]

Patch to make averages actually averages in the Hadoops metric package.

[Owen O'Malley]

0.18.1 has already been released.

[Johan Oskarsson]

For some reason this hasn't been run through hudson, could you resubmit the patch Brian?

[Robert Chansler]

See if Hudson will do the test.

In any case, Nicholas will review the change.

Promote for 19.

[Tsz Wo (Nicholas), SZE]

+1 patch looks good

[Tsz Wo (Nicholas), SZE]

re-submitting ...

[Tsz Wo (Nicholas), SZE]

 
    [exec] -1 overall.  

     [exec]     +1 @author.  The patch does not contain any @author tags.

     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no tests are needed for this patch.

     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.

     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.

     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

The change is simple. We don't need a new test here.

[Tsz Wo (Nicholas), SZE]

It passed all tests in my local machine.

I just committed this. Thanks, Brian.

[Hudson]

Integrated in Hadoop-trunk #640 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/640/)