[HADOOP-4364] IPC.Client.handleConnectionFailure should bail out if the retry count is >= the maximum, not ==

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 0.20.0
• Component/s: ipc
• Labels: newbie
• Assignee: Unassigned
• Reporter: Steve Loughran
• Created: 07/Oct/08 13:39
• Updated: 18/Jul/14 23:58

Description

Looking at the code in IPC.Client.handleConnectionFailure(), its clear that the connection setup exits if the client retrys equals the maximum specified

if (curRetries == maxRetries)

{ throw ioe; }

But there's nothing to stop anyone setting ipc.client.connect.max.retries=0 in the configuration, and if that happens, the code will spin until the (integer) retry count wraps around. The test should be curRetries >= maxRetries