In "ant test-patch", runContribTestOnEclipseFiles should not be run on Hudson only

• Key: HADOOP-4244
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Tsz Wo (Nicholas), SZE
• Reporter: Tsz Wo (Nicholas), SZE
• Component/s: build, test
• Fix Version/s: 0.20.0

Description

runContribTestOnEclipseFiles is ONLY executed on Hudson but it won't be executed by default. So it won't be run when developers run "ant test-patch".

Comments

[Tsz Wo (Nicholas), SZE]

There are probably bugs in runContribTests(). It gives a -1 even if there is no tests fails. For example,
see https://issues.apache.org/jira/browse/HADOOP-4242?focusedCommentId=12633545#action_12633545

[Nigel Daley]

Nicholas, the -1 comes from the eclipse plugin classpath check that someone put into test-patch. At the end of the build, you can see:

[exec] FAILED. Some jars are not declared in the Eclipse project.
[exec] Declared jars: lib/clover.jar
[exec] lib/commons-cli-2.0-SNAPSHOT.jar
[exec] lib/commons-codec-1.3.jar
[exec] lib/commons-httpclient-3.0.1.jar
[exec] lib/commons-logging-1.0.4.jar
[exec] lib/commons-logging-api-1.0.4.jar
[exec] lib/commons-net-1.4.1.jar
[exec] lib/excluded/checkstyle-all-4.3.jar
[exec] lib/jets3t-0.6.1.jar
[exec] lib/jetty-5.1.4.jar
[exec] lib/jetty-ext/commons-el.jar
[exec] lib/jetty-ext/jasper-compiler.jar
[exec] lib/jetty-ext/jasper-runtime.jar
[exec] lib/jetty-ext/jsp-api.jar
[exec] lib/junit-3.8.1.jar
[exec] lib/kfs-0.2.0.jar
[exec] lib/log4j-1.2.15.jar
[exec] lib/oro-2.0.8.jar
[exec] lib/servlet-api.jar
[exec] lib/slf4j-api-1.4.3.jar
[exec] lib/slf4j-log4j12-1.4.3.jar
[exec] lib/xmlenc-0.52.jar
[exec] src/test/lib/ftplet-api-1.0.0-SNAPSHOT.jar
[exec] src/test/lib/ftpserver-core-1.0.0-SNAPSHOT.jar
[exec] src/test/lib/ftpserver-server-1.0.0-SNAPSHOT.jar
[exec] src/test/lib/mina-core-2.0.0-M2-20080407.124109-12.jar
[exec] Present jars: lib/clover.jar
[exec] lib/commons-cli-2.0-SNAPSHOT.jar
[exec] lib/commons-codec-1.3.jar
[exec] lib/commons-httpclient-3.0.1.jar
[exec] lib/commons-logging-1.0.4.jar
[exec] lib/commons-logging-api-1.0.4.jar
[exec] lib/commons-net-1.4.1.jar
[exec] lib/excluded/checkstyle-all-4.3.jar
[exec] lib/hsqldb.jar
[exec] lib/jets3t-0.6.1.jar
[exec] lib/jetty-5.1.4.jar
[exec] lib/jetty-ext/commons-el.jar
[exec] lib/jetty-ext/jasper-compiler.jar
[exec] lib/jetty-ext/jasper-runtime.jar
[exec] lib/jetty-ext/jsp-api.jar
[exec] lib/junit-3.8.1.jar
[exec] lib/kfs-0.2.0.jar
[exec] lib/log4j-1.2.15.jar
[exec] lib/oro-2.0.8.jar
[exec] lib/servlet-api.jar
[exec] lib/slf4j-api-1.4.3.jar
[exec] lib/slf4j-log4j12-1.4.3.jar
[exec] lib/xmlenc-0.52.jar
[exec] src/test/lib/ftplet-api-1.0.0-SNAPSHOT.jar
[exec] src/test/lib/ftpserver-core-1.0.0-SNAPSHOT.jar
[exec] src/test/lib/ftpserver-server-1.0.0-SNAPSHOT.jar
[exec] src/test/lib/mina-core-2.0.0-M2-20080407.124109-12.jar

[Tsz Wo (Nicholas), SZE]

I created HADOOP-4249 and submitted a patch for adding hsqldb.jar in the eclipse templates. How can I test it locally?

[Vinod K V]

I remember that a similar problem occurred a while ago too. It could have been much easier to spot this had Hudson explicitly pointed out the jars that were missing/extra, saving us from iterating through the whole list of jars and finding out the culprit.

[Tsz Wo (Nicholas), SZE]

4244_20080924.patch: separate eclipse tests and contrib tests

[Nigel Daley]

Patch review:

"Running Eclipse tests." ->
"Running Eclipse classpath verification."

"-1 Eclipse tests. The patch failed Eclipse unit tests." ->
"+1 Eclipse classpath. The patch causes the Eclipse classpath to differ from the contents of the lib directory."

"+1 Eclipse tests. The patch passed Eclipse unit tests." ->
"+1 Eclipse tests. The patch retains Eclipse classpath integrity."

[Tsz Wo (Nicholas), SZE]

4244_20080924b.patch: updated the messages

[Nigel Daley]

+1. Please commit WITHOUT marking Patch Available. This patch can't be tested properly by Hudson since it modifies the script that Hudson runs.

[Tsz Wo (Nicholas), SZE]

Thanks Nigel for reviewing.

I just committed this.

[Hudson]

Integrated in Hadoop-trunk #615 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/615/)