Issue Details (XML | Word | Printable)

Key: HADOOP-4150
Type: Wish Wish
Status: Closed Closed
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Giridharan Kesavan
Reporter: Koji Noguchi
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Hadoop Common

Include librecordio as part of the release

Created: 10/Sep/08 08:37 PM   Updated: 30/Jan/09 08:14 PM
Return to search
Component/s: build
Affects Version/s: None
Fix Version/s: 0.18.3

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works HADOOP-4150.patch 2008-10-14 07:14 AM Giridharan Kesavan 10 kB

Release Note: Included librecordio in release for use by xerces-c (ant -Dlibrecordio=true -Dxercescroot=<path to the xerces-c root>)
Resolution Date: 13/Nov/08 11:56 PM


 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Christian Kunz added a comment - 10/Sep/08 08:43 PM
+1

Nigel Daley added a comment - 30/Sep/08 03:05 PM
There are no ant targets for librecordio. I'm compiling like this:
export XERCESCROOT=...
export HADOOP_HOME=...
cd src/c++/librecordio
make

Giridharan Kesavan added a comment - 14/Oct/08 07:07 AM
After discussion with Nigel here with attached a patch to resolve this issue.

librecordio has a build dependency with xerces-c parser. so to get this build; need to set the path of xerces-c binary to xercescroot and librecordio to true
exact command would be like this :

ant -Dlibrecordio=true -Dxercescroot=<path to the xerces-c root>

This patch includes targets for compiling, packaging and testing the librecordio library.


Hadoop QA added a comment - 14/Oct/08 01:48 PM
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12392068/HADOOP-4150.patch
against trunk revision 704310.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 19 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3457/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3457/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3457/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3457/console

This message is automatically generated.


Arun C Murthy added a comment - 14/Oct/08 11:03 PM
I just committed this. Thanks, Giridharan!

Hudson added a comment - 15/Oct/08 01:56 PM
Integrated in Hadoop-trunk #634 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/634/)
. Include librecordio in hadoop releases. Contributed by Giridharan Kesavan.

Nigel Daley added a comment - 20/Oct/08 11:07 PM

Robert Chansler added a comment - 05/Nov/08 10:59 PM
Will this patch apply correctly to 0.18?
Thanks!

Giridharan Kesavan added a comment - 11/Nov/08 11:16 AM
This patch is applicable to 0.18 as well.
And yes, I 've tested this patch on 0.18 branch and it works just fine.

Nigel Daley added a comment - 13/Nov/08 11:56 PM
Merged to branch-0.18

Hudson added a comment - 14/Nov/08 06:33 PM
Integrated in Hadoop-trunk #661 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/661/)
: merged to branch-0.18 so updated CHANGES.txt