[#HADOOP-4046] WritableComparator's constructor should be protected instead of private

Hadoop Common

WritableComparator's constructor should be protected instead of private

Created: 29/Aug/08 05:14 PM Updated: 18/Sep/08 05:55 PM

Component/s:

Affects Version/s:

0.18.0

Fix Version/s:

0.18.1

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	4046-0.patch	2008-09-01 09:17 PM	Chris Douglas	2 kB

Hadoop Flags:	Reviewed
Resolution Date:	02/Sep/08 04:31 PM

Description

« Hide

Currently, it isn't possible to subclass WritableComparator in a meaningful way. We should make this constructor protected:

private WritableComparator(Class keyClass, boolean createInstances)

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Chris Douglas added a comment - 01/Sep/08 09:24 PM

Attaching a patch making WritableComparator effectively extensible. The performance penalty for a pair of deserializations for each compare in both the sort and merge is difficult to overstate, but for prototyping in particular this can be useful.

[ Permlink | « Hide ]

Hadoop QA added a comment - 02/Sep/08 07:47 AM

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12389315/4046-0.patch
against trunk revision 691099.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3156/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3156/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3156/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3156/console

This message is automatically generated.

[ Permlink | « Hide ]

Owen O'Malley added a comment - 02/Sep/08 04:31 PM

I just committed this. Thanks, Chris!

[ Permlink | « Hide ]

Hudson added a comment - 06/Sep/08 01:23 PM

Integrated in Hadoop-trunk #595 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/595/)