[#HADOOP-3995] renameTo(src, dst) does not restore src name in case of quota failure. - ASF JIRA

Issue Details (XML | Word | Printable)

Key:	HADOOP-3995
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Blocker
Assignee:	Raghu Angadi
Reporter:	Raghu Angadi
Votes:	0
Watchers:	0

Operations

If you were logged in you would be able to see more operations.

Hadoop Common

renameTo(src, dst) does not restore src name in case of quota failure.

Created: 22/Aug/08 04:32 AM Updated: 08/Jul/09 04:43 PM

Component/s:

None

Affects Version/s:

0.18.0

Fix Version/s:

0.18.1

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	HADOOP-3995-018.patch	2008-08-22 04:17 PM	Raghu Angadi	2 kB
	HADOOP-3995-018.patch	2008-08-22 04:15 PM	Raghu Angadi	2 kB
	HADOOP-3995-trunk.patch	2008-08-22 06:30 PM	Raghu Angadi	2 kB

Hadoop Flags:	Reviewed
Release Note:	« Hide In case of quota failure on HDFS, rename does not restore source filename. Show » In case of quota failure on HDFS, rename does not restore source filename.
Resolution Date:	27/Aug/08 01:29 AM

Description

How to reproduce :

set up quota such that 'hadoop -mv src dst' results in a 'quota excceeded' exception.

Now try : hadoop -mv src dst/diffname
- This fails as expected
- buf 'src' does not exist after this, you will find 'diffname' directory in its place

I think fix should go into 0.18.1

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Raghu Angadi added a comment - 22/Aug/08 04:15 PM

A simple fix is attached. This adds a test case in TestQuota

[ Permlink | « Hide ]

Hadoop QA added a comment - 26/Aug/08 03:50 AM

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12388759/HADOOP-3995-trunk.patch
against trunk revision 688936.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

-1 javadoc. The javadoc tool appears to have generated 1 warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3100/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3100/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3100/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3100/console

This message is automatically generated.

[ Permlink | « Hide ]

Hairong Kuang added a comment - 26/Aug/08 04:30 PM

+1 The patch looks good.

[ Permlink | « Hide ]

Raghu Angadi added a comment - 26/Aug/08 05:34 PM

Javadoc warnings are unrelated.

[ Permlink | « Hide ]

Raghu Angadi added a comment - 27/Aug/08 01:29 AM

I just committeted this.

[ Permlink | « Hide ]

Hudson added a comment - 28/Aug/08 02:15 PM

Integrated in Hadoop-trunk #586 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/586/)