[#HADOOP-3986] JobClient should not have a static configuration

Hadoop Common

JobClient should not have a static configuration

Created: 21/Aug/08 04:42 AM Updated: 08/Jul/09 04:53 PM

Return to search

Component/s:

None

Affects Version/s:

0.18.0

Fix Version/s:

0.20.0

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	patch-3986.txt	2008-11-20 06:38 AM	Amareshwari Sriramadasu	10 kB

Issue Links:

Blocker

This issue is blocked by:

~~HADOOP-4612~~ Remove RunJar's dependency on JobClient

~~HADOOP-3722~~ Provide a unified way to pass jobconf options from bin/hadoop

Hadoop Flags:	Reviewed, Incompatible change
Release Note:	Removed classes org.apache.hadoop.mapred.JobShell and org.apache.hadoop.mapred.TestJobShell. Removed from JobClient methods static void setCommandLineConfig(Configuration conf) and public static Configuration getCommandLineConfig().
Resolution Date:	25/Nov/08 09:30 AM

Description

« Hide

Post ~~HADOOP-3743~~ use of static commandLineConfig and JobShell is deprecated. They should be removed.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Amareshwari Sriramadasu added a comment - 21/Aug/08 04:43 AM

This issue requires streaming and pipes to implement Tool.

[ Permlink | « Hide ]

Amareshwari Sriramadasu added a comment - 20/Nov/08 06:38 AM

Attaching patch which removes JobShell and static Configuration from JobClient.

[ Permlink | « Hide ]

Hadoop QA added a comment - 22/Nov/08 09:57 AM

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12394317/patch-3986.txt
against trunk revision 719787.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 10 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3629/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3629/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3629/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3629/console

This message is automatically generated.

[ Permlink | « Hide ]

Amareshwari Sriramadasu added a comment - 24/Nov/08 03:26 AM

Test failure org.apache.hadoop.hdfs.TestDatanodeBlockScanner.testBlockCorruptionRecoveryPolicy is not related to the patch.

[ Permlink | « Hide ]

Chris Douglas added a comment - 25/Nov/08 09:30 AM

+1 Looks good. JobShell wasn't deprecated, but there has been ample warning since ~~HADOOP-3743~~.

I just committed this. Thanks Amareshwari

[ Permlink | « Hide ]

Hudson added a comment - 25/Nov/08 06:39 PM

Integrated in Hadoop-trunk #670 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/670/)
. Remove static Configuration from JobClient. Contributed by Amareshwari Sriramadasu.

[ Permlink | « Hide ]

Robert Chansler added a comment - 03/Mar/09 01:48 AM

Edit release note for publication.