Issue Details (XML | Word | Printable)

Key: HADOOP-3934
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Owen O'Malley
Reporter: Don Kim
Votes: 0
Watchers: 3
Operations

If you were logged in you would be able to see more operations.
Hadoop Common

Update log4j from 1.2.13 to 1.2.15

Created: 11/Aug/08 07:49 PM   Updated: 18/Sep/08 05:55 PM
Component/s: None
Affects Version/s: 0.18.0
Fix Version/s: 0.18.1

Time Tracking:
Not Specified

Resolution Date: 18/Aug/08 10:17 PM


 Description  « Hide
Hadoop is currently using log4j version 1.2.13 and this version does not support the use of a non-default syslog port when specifying the syslog server destination. Syslogging is important to us and even more so with audit logging introduced in hadoop-0.18. The current released version of log4j is 1.2.15 which does support the use of specifying a non-default syslog port (introduced in log4j 1.2.14) as well as many other syslog enhancements and fixes (http://logging.apache.org/log4j/1.2/changes-report.html).

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Allen Wittenauer added a comment - 11/Aug/08 10:31 PM
I'm going to mark this as a blocker for 0.18.

Given the reported performance hits that we're seeing with log4j and audit logging, I don't think it is going to be possible for us to upgrade to 0.18 and turn on audit logging without this fix in place. [... and we desperately need audit logging for metrics and security reasons.]


Robert Chansler added a comment - 16/Aug/08 12:32 AM
I surveyed some of the usual suspects, and failed to confirm that this is an urgent performance issue. Satisfactory performance was reported in one large test.

That said, moving to the next version of Log4J is a Good Thing for the reasons reported by Don.

(The reason that this is a non-trivial upgrade is that Hadoop is built with a non-standard version of Log4J. Transition to a released version requires some deliberation.)


Steve Loughran added a comment - 18/Aug/08 01:30 PM
> Hadoop is built with a non-standard version of Log4J

I don't see that

hadoop-core> md5sum lib/log4j-1.2.13.jar
52169b4a318e3246483f39f62b84b948 lib/log4j-1.2.13.jar

~/.ivy2/cache/log4j/log4j/jars> md5sum log4j-1.2.13.jar
52169b4a318e3246483f39f62b84b948 log4j-1.2.13.jar

Looks like a standard release to me, or at least to md5sum.


Owen O'Malley added a comment - 18/Aug/08 10:17 PM
I just committed this to trunk after running unit tests. If we feel we need to add this to 18.1, that can be done after 18.0 is tagged.

Hudson added a comment - 22/Aug/08 12:34 PM

Owen O'Malley added a comment - 09/Sep/08 08:36 PM
This was needed for 0.18 deployment. I also included the fix from HADOOP-4037.

Hudson added a comment - 11/Sep/08 01:04 PM