Deprecate org.apache.hadoop.mapred.StatusHttpServer

• Key: HADOOP-3923
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Tsz Wo (Nicholas), SZE
• Reporter: Tsz Wo (Nicholas), SZE
• Fix Version/s: 0.20.0

Description

StatusHttpServer is extending org.apache.hadoop.http.HttpServer. The only additional feature in StatusHttpServer is TaskGraphServlet. StatusHttpServer is used by TaskTracker and JobTracker. It turns that only JobTracker uses TaskGraphServlet but not TaskTracker.

So, we should deprecate StatusHttpServer, let TaskTracker and JobTracker use HttpServer directly, and add TaskGraphServlet to JobTracker.

Comments

[Tsz Wo (Nicholas), SZE]

3923_20081111.patch: talked to Owen, this class is better removed directly.

[Tsz Wo (Nicholas), SZE]

3923_20081111b.patch: Fixed a findbugs warning existing in the old codes.

[Lohit Vijayarenu]

Would it be better to have StatusHttpServer change to JobTrackerStatusHttpServer and TaskTracker use HttpServer for now. In that way added new servlets specific to JobTracker would be easy addition to JobTrackerStatusHttpServer.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12393719/3923_20081111b.patch
against trunk revision 713106.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

-1 javac. The applied patch generated 220 javac compiler warnings (more than the trunk's current 1011 warnings).

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3577/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3577/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3577/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3577/console

This message is automatically generated.

[Tsz Wo (Nicholas), SZE]

Hi Lohit, are you saying that we should keep TaskGraphServlet in JobTrackerStatusHttpServer? Without TaskGraphServlet, JobTrackerStatusHttpServer is quite empty and may not deserve to have a class for that. If we keep TaskGraphServlet in JobTrackerStatusHttpServer and put future servlet classes as static classes in JobTrackerStatusHttpServer, it will make JobTrackerStatusHttpServer unnecessary messy. So it might be better to remove this not-so-useful class. No?

[Lohit Vijayarenu]

Ok, if more servlets are added we could think about it. You changes looks good. Thanks.

[Tsz Wo (Nicholas), SZE]

Thanks, Lohit.

BTW, I didn't introduce 220 javac compiler warnings, see HADOOP-4634. This is a code clean up. So no new tests added.

[Tsz Wo (Nicholas), SZE]

I checked the web page manually. Everything looks good.

[Tsz Wo (Nicholas), SZE]

I just committed this.

[Hudson]

Integrated in Hadoop-trunk #659 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/659/)
. Remove org.apache.hadoop.mapred.StatusHttpServer. (szetszwo)

[Robert Chansler]

Edit release note for publication.