Fix TaskTracker's heartbeat timer to note the time the hearbeat RPC returned to decide next heartbeat time

• Key: HADOOP-3875
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Arun C Murthy
• Reporter: Arun C Murthy
• Affects Version/s: 0.18.0
• Fix Version/s: 0.19.0

Description

The tasktracker notes the time the heartbeat RPC was fired, rather than when it returned to decide when to send the next one. If the RPC spends a lot of time in the JobTracker's queue then the above exacerbates the load on the JobTracker.

Comments

[Arun C Murthy]

Also, there is a redundant call to System.currentTime in TaskTracker.transmitHeartbeat - that information is already available at TaskTracker.offerService, we should just pass it down.

[Arun C Murthy]

Straight-forward patch...

[Amareshwari Sriramadasu]

+1

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12387250/HADOOP-3875_0_20080730.patch
against trunk revision 681243.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2990/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2990/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2990/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2990/console

This message is automatically generated.

I just committed this. Thanks, Arun!

[Hudson]

Integrated in Hadoop-trunk #581 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/581/)