[#HADOOP-3791] Use generics in ReflectionUtils

Hadoop Common

Use generics in ReflectionUtils

Created: 18/Jul/08 05:20 PM Updated: 08/Jul/09 04:53 PM

Return to search

Component/s:

None

Affects Version/s:

None

Fix Version/s:

0.19.0

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
hadoop-generics.patch	2008-07-23 01:54 PM	Chris Smith	69 kB
hadoop-generics.patch	2008-07-18 05:20 PM	Chris Smith	63 kB

Hadoop Flags:	Reviewed
Resolution Date:	30/Jul/08 10:45 PM

Description

« Hide

The attached patch makes ReflectionUtils.newInstance use generics appropriately. I've also gone through and updated everywhere that calls ReflectionUtils.newInstance to remove now-redundant casts, or to add further generics where appropriate. The overall result is about 17 fewer @SupressWarnings("unchecked") needed in the source tree.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#681235	Wed Jul 30 22:45:41 UTC 2008	cdouglas	~~HADOOP-3791~~. Introduce generics into ReflectionUtils. Contributd by Chris Smith.
				Files Changed
				MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/SequenceFileAsBinaryOutputFormat.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/io/compress/CompressionCodecFactory.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/TextOutputFormat.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/fs/FsShell.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/MapFileOutputFormat.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/util/PriorityQueue.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/MapRunner.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/Merger.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/io/SortedMapWritable.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/FileInputFormat.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/io/SetFile.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/join/CompositeRecordReader.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/io/SequenceFile.java MODIFY /hadoop/core/trunk/src/test/org/apache/hadoop/util/TestReflectionUtils.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/SequenceFileOutputFormat.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/record/RecordComparator.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/lib/MultithreadedMapRunner.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/MapTask.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobConf.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/io/ArrayWritable.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/join/CompositeInputSplit.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/io/MapFile.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/pipes/Submitter.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/pipes/PipesReducer.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/io/GenericWritable.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/IsolationRunner.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/lib/MultipleSequenceFileOutputFormat.java MODIFY /hadoop/core/trunk/src/examples/org/apache/hadoop/examples/dancing/DistributedPentomino.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapreduce/JobContext.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/ReduceTask.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/lib/MultipleOutputs.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/join/ArrayListBackedIterator.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/Task.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/io/WritableName.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/io/WritableFactories.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/ipc/Client.java MODIFY /hadoop/core/trunk/src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/pipes/PipesPartitioner.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTracker.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/util/ReflectionUtils.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/pipes/Application.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/ipc/Server.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/Counters.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/io/MapWritable.java MODIFY /hadoop/core/trunk/CHANGES.txt MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/io/AbstractMapWritable.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/SequenceFileRecordReader.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/pipes/PipesMapRunner.java MODIFY /hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/join/CompositeInputFormat.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/io/WritableComparator.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/io/ArrayFile.java MODIFY /hadoop/core/trunk/src/test/org/apache/hadoop/mapred/join/FakeIF.java MODIFY /hadoop/core/trunk/src/core/org/apache/hadoop/io/WritableUtils.java