The data_join should allow the user to implement a customer cloning function

• Key: HADOOP-3684
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Runping Qi
• Reporter: Runping Qi
• Fix Version/s: 0.19.0

Description

Currently, the framework uses serialization/deserialization to clone the values passed to the resuce function.
This amounts to a very heavy weight deep copy of the value objects.
That is way too expensive. Although that may be a generic way to work for all possible value classes, thus good as a default way,
the framework should allow the user to implemet an application specific yet efficient cloning function.

Comments

[Runping Qi]

Attach a simple patch.

This patch allows the user to overwrite the clone(JobConf job)
method in the subclass of TaggedMapOutputclass.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12385153/H-3684.txt
against trunk revision 673517.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

-1 patch. The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2786/console

This message is automatically generated.

[Runping Qi]

regenerate the patch

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12385161/H-3684.txt
against trunk revision 673517.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2789/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2789/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2789/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2789/console

This message is automatically generated.

[Chris Douglas]

+1

[Chris Douglas]

I just committed this. Thanks, Runping

[Hudson]

Integrated in Hadoop-trunk #581 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/581/)