[#HADOOP-3511] Namenode should not restore the root's quota if the quota was not in the image

Hadoop Common

Namenode should not restore the root's quota if the quota was not in the image

Created: 06/Jun/08 11:12 PM Updated: 22/Aug/08 07:50 PM

Return to search

Component/s:

None

Affects Version/s:

0.18.0

Fix Version/s:

0.18.0

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	rootQuota.patch	2008-06-06 11:19 PM	Hairong Kuang	1 kB

Hadoop Flags:	Reviewed
Resolution Date:	07/Jun/08 12:03 AM

Description

« Hide

When namenode loads the image, it sets the root's quota to be an invalid value when the quota was not saved in the image.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Hairong Kuang added a comment - 06/Jun/08 11:19 PM

The patch fixes the problem.

Hairong Kuang made changes - 06/Jun/08 11:19 PM

Field	Original Value	New Value
Attachment		rootQuota.patch [ 12383608 ]

Hairong Kuang made changes - 06/Jun/08 11:20 PM

Affects Version/s		0.18.0 [ 12312972 ]
Assignee		Hairong Kuang [ hairong ]
Fix Version/s		0.18.0 [ 12312972 ]

Hairong Kuang made changes - 06/Jun/08 11:20 PM

Status

Open [ 1 ]

Patch Available [ 10002 ]

[ Permlink | « Hide ]

Tsz Wo (Nicholas), SZE added a comment - 06/Jun/08 11:21 PM

+1 patch looks good

Tsz Wo (Nicholas), SZE made changes - 06/Jun/08 11:21 PM

Hadoop Flags

[Reviewed]

Hairong Kuang made changes - 06/Jun/08 11:28 PM

Description

When namenode load the image, it should set the root's quota to be an invalid value when the quota was not saved in the image.

When namenode loads the image, it sets the root's quota to be an invalid value when the quota was not saved in the image.

[ Permlink | « Hide ]

Hairong Kuang added a comment - 06/Jun/08 11:54 PM

ant patch result:

[exec] BUILD SUCCESSFUL
[exec] Total time: 5 minutes 52 seconds
[exec] Starting with ../tmp/trunkFindbugsWarnings.xml
[exec] Merging ../tmp/patchFindbugsWarnings.xml

[exec] -1 overall.

[exec] +1 @author. The patch does not contain any @author tags.

[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.

[exec] +1 javadoc. The javadoc tool did not generate any warning messages.

[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.

[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.

The 1 line change patch was tested manually. So no unit test is provided.

Repository	Revision	Date	User	Message
ASF	#664205	Sat Jun 07 00:02:07 UTC 2008	hairong	~~HADOOP-3511~~. Namenode should not restore the root's quota if the quota was not saved in the image. Contributed by Hairong Kuang.
				Files Changed
				MODIFY /hadoop/core/trunk/CHANGES.txt MODIFY /hadoop/core/trunk/src/java/org/apache/hadoop/dfs/FSImage.java MODIFY /hadoop/core/trunk/src/java/org/apache/hadoop/dfs/QuotaExceededException.java

[ Permlink | « Hide ]

Hairong Kuang added a comment - 07/Jun/08 12:03 AM

I just committed this.

Hairong Kuang made changes - 07/Jun/08 12:03 AM

Resolution		Fixed [ 1 ]
Status	Patch Available [ 10002 ]	Resolved [ 5 ]

Nigel Daley made changes - 22/Aug/08 07:50 PM

Status

Resolved [ 5 ]

Closed [ 6 ]