FSNamesystem.close() throws NullPointerException

• Key: HADOOP-3509
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Tsz Wo (Nicholas), SZE
• Reporter: Tsz Wo (Nicholas), SZE
• Fix Version/s: 0.18.0

Description

During NameNode startup, if there is an exception thrown before FSNamesystem.dir is created, we will get a NullPointerException.

2008-06-06 12:07:21,203 ERROR org.apache.hadoop.dfs.NameNode: java.lang.NullPointerException
	at org.apache.hadoop.dfs.FSNamesystem.close(FSNamesystem.java:465)
	at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:253)
	at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:148)
	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:193)
	at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:179)
	at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:822)
	at org.apache.hadoop.dfs.NameNode.main(NameNode.java:831)

Comments

[Tsz Wo (Nicholas), SZE]

3509_20080606.patch: check null before calling close(). I tested manually. No new tests added.

[Tsz Wo (Nicholas), SZE]

3509_20080606b.patch: added IOUtils.close(...)

[Konstantin Shvachko]

+1
This is good. I like IOUtils.close().

3509_20080606c.patch: updated javadoc

[Tsz Wo (Nicholas), SZE]

Passed ant test and ant test-patch locally.

     [exec]     +1 @author.  The patch does not contain any @author tags.

     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no tests are needed for this patch.

     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.

     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.

[Konstantin Shvachko]

I just committed this. Thank you Nicholas.