Issue Details (XML | Word | Printable)

Key: HADOOP-3390
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Tsz Wo (Nicholas), SZE
Reporter: Tsz Wo (Nicholas), SZE
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Hadoop Common

Remove deprecated ClientProtocol.abandonFileInProgress()

Created: 14/May/08 05:49 PM   Updated: 08/Jul/09 04:43 PM
Return to search
Component/s: None
Affects Version/s: None
Fix Version/s: 0.18.0

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works 3390_20080514.patch 2008-05-14 06:00 PM Tsz Wo (Nicholas), SZE 5 kB

Hadoop Flags: Reviewed, Incompatible change
Release Note: Removed deprecated ClientProtocol.abandonFileInProgress().
Resolution Date: 14/May/08 11:25 PM


 Description  « Hide
ClientProtocol.abandonFileInProgress() was deprecated in 0.17 and is not used anywhere currently.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Tsz Wo (Nicholas), SZE added a comment - 14/May/08 06:00 PM
3390_20080514.patch: Remove ClientProtocol.abandonFileInProgress()

dhruba borthakur added a comment - 14/May/08 06:24 PM
There was talk earlier about having a Java like API deleteOnExit() for HDFS files. That feature could use abandonFileInProgress but is better handled entirely in the client code. We do not need an special RPC to delete it.

+1 for this one.

This is an incompatible change.


Hadoop QA added a comment - 14/May/08 11:04 PM
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12382061/3390_20080514.patch
against trunk revision 656270.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2470/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2470/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2470/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2470/console

This message is automatically generated.


Raghu Angadi added a comment - 14/May/08 11:25 PM
I just committed this. Thanks Nicholas.

Hudson added a comment - 15/May/08 12:43 PM