Deprecate org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)

• Key: HADOOP-3202
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Amareshwari Sriramadasu
• Reporter: Tsz Wo (Nicholas), SZE
• Component/s: fs
• Fix Version/s: 0.19.0

Description

We should use FileSystem.delete(path, recursive=true) instead.
See also https://issues.apache.org/jira/browse/HADOOP-771?focusedCommentId=12586566#action_12586566

Comments

[Arun C Murthy]

+1

[Amareshwari Sriramadasu]

Here is a patch deprecating FileUtil.fullyDelete(FileSystem, Path)

[Amareshwari Sriramadasu]

Fixed a javadoc warning in the earlier patch.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12386870/patch-3202.txt
against trunk revision 679772.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 6 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

-1 javac. The applied patch generated 522 javac compiler warnings (more than the trunk's current 521 warnings).

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2952/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2952/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2952/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2952/console

This message is automatically generated.

[Tsz Wo (Nicholas), SZE]

+1 patch looks good. The new javac warning is about that DistCp is still using the deprecated FileUtil.fullyDelete(...). We could fix it here or later.

[Amareshwari Sriramadasu]

Fixed javac warning

[Hadoop QA]

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12387003/patch-3202.txt
against trunk revision 679930.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 6 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2958/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2958/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2958/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2958/console

This message is automatically generated.

[Owen O'Malley]

I just committed this. Thanks, Amareshwari!

[Hudson]

Integrated in Hadoop-trunk #581 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/581/)