add name of faulty class to WritableName.getClass IOException upon ClassNotFoundException

• Key: HADOOP-3180
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Trivial
• Assignee: Pete Wyckoff
• Reporter: Pete Wyckoff
• Component/s: io
• Fix Version/s: 0.20.0

Description

WritableName.getClass raises an IOException when it cannot load the class. The message is "WritableName can't load class" without the name of the class. Although one can get this from getCause, easier to see it just from the message.

propose change it to:

IOException newE = new IOException("WritableName can't load class: " + name);

I will attach a patch.

Comments

[Pete Wyckoff]

just add name of the class that WritableNAme.getClass cant get in the exception it throws.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12379435/patch.txt
against trunk revision 643282.

@author +1. The patch does not contain any @author tags.

tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests -1. The patch failed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2168/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2168/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2168/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2168/console

This message is automatically generated.

[Pete Wyckoff]

I think the tests had RPC timeouts that prevented it from passing - nothing to do with the patch.

[Pete Wyckoff]

same thing re-submitted to try QA again since I don't think the last failure was due to the patch but rather just a random failure.

Note, no unit tests because so trivial and only fix for debugging.

[Pete Wyckoff]

patch2.txt

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12380533/patch2.txt
against trunk revision 645773.

@author +1. The patch does not contain any @author tags.

tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests +1. The patch passed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2283/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2283/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2283/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2283/console

This message is automatically generated.

[Pete Wyckoff]

I don't know where to put this comment, but this is only a change to a LOG.error stmt in adding a String variable to it, so it's not really worth doing a test on it...

[Owen O'Malley]

Pete, please add a test. Consistently adding tests when changes are made is by far the best way to have a large deep regression test suite, which helps future development. It is unlikely that branch has been covered by another test case.

[Pete Wyckoff]

sure, owen will do. Will have to remember how I was able to generate this exception I think it was because I didnt have all our Writable classes in the classpath.

I'll get it together but may need help on how to create the test as I would have to create a file with a custom Writable key but then remove that writable class from the running test and try to read the file.

[Pete Wyckoff]

The fix + complete unit tests for WritableName.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390804/HADOOP-3180.1.txt
against trunk revision 699119.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3376/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3376/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3376/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3376/console

This message is automatically generated.

[Owen O'Malley]

I just committed this. Thanks, Pete!

[Hudson]

Integrated in Hadoop-trunk #620 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/620/)
. Add name of missing class to WritableName.getClass
IOException. (Pete Wyckoff via omalley)