[#HADOOP-3176] Change lease record when a open-for-write-file gets renamed

Hadoop Common

Change lease record when a open-for-write-file gets renamed

Created: 04/Apr/08 08:41 PM Updated: 08/Jul/09 04:43 PM

Component/s:

None

Affects Version/s:

None

Fix Version/s:

0.18.0

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
danglingLease.patch	2008-04-13 07:23 AM	dhruba borthakur	13 kB
danglingLease2.patch	2008-04-15 07:08 PM	dhruba borthakur	11 kB

Issue Links:

Blocker

This issue blocks:

~~HADOOP-1700~~ Append to files in HDFS

Reference

This issue relates to:

~~HADOOP-3083~~ Remove lease when file is renamed

Hadoop Flags:	Reviewed
Resolution Date:	16/Apr/08 04:56 AM

Description

« Hide

When a file/directory is removed, the namenode should repair the leases so that the existing leases point to the appropriate file. The lease record has the pathname of the file that it refers to.

This is required because the namenode has to invoke lease-recovery on the correct file if the client that was writing to a file dies.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

dhruba borthakur added a comment - 13/Apr/08 07:23 AM

When a file is renamed, change the name of affected lease records.

[ Permlink | « Hide ]

Hadoop QA added a comment - 13/Apr/08 08:48 AM

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12379994/danglingLease.patch
against trunk revision 645773.

@author +1. The patch does not contain any @author tags.

tests included +1. The patch appears to include 3 new or modified tests.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs -1. The patch appears to introduce 2 new Findbugs warnings.

core tests +1. The patch passed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2222/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2222/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2222/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2222/console

This message is automatically generated.

[ Permlink | « Hide ]

dhruba borthakur added a comment - 15/Apr/08 07:08 PM

1. Fixed findbugs warnings.
2. Enhanced test case by renaming a directory that has two open files in its subdirectory.
3. Removed LeaseComparator
4. All debug logs are encapsulated inside IsDebugEnabled()