Writable for single byte and double

• Key: HADOOP-3061
• Type: New Feature
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Andrzej Bialecki
• Reporter: Andrzej Bialecki
• Component/s: io
• Affects Version/s: 0.17.0
• Fix Version/s: 0.18.0

Description

Implementations of Writable for a single byte and a double.

Comments

[Doug Cutting]

readLong() and readFloat(), and readInt() should not be defined in FloatWritable, since they're already defined in WritableCompator. Other than that, this looks good.

[Alan Gates]

Here's the same patch with readDouble, readLong, and readInt removed from DoubleWritable, per Doug's comments.

[Hadoop QA]

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12380198/writable_v2.patch
against trunk revision 645773.

@author +1. The patch does not contain any @author tags.

tests included +1. The patch appears to include 3 new or modified tests.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests +1. The patch passed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2243/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2243/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2243/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2243/console

This message is automatically generated.

[Owen O'Malley]

I just committed this. Thanks, Andrzej!

[Hudson]

Integrated in Hadoop-trunk #469 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/469/)