Issue Details (XML | Word | Printable)

Key: HADOOP-3060
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Amareshwari Sriramadasu
Reporter: Amareshwari Sriramadasu
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Hadoop Common

MiniMRCluster is ignoring parameter taskTrackerFirst

Created: 20/Mar/08 07:23 AM   Updated: 08/Jul/09 04:52 PM
Return to search
Component/s: None
Affects Version/s: None
Fix Version/s: 0.17.0

Time Tracking:
Not Specified

File Attachments:
  File Name Date Attached Attached By Size
Text File Licensed for inclusion in ASF works patch-3060.txt 2008-03-26 04:51 AM Amareshwari Sriramadasu 4 kB
Text File Licensed for inclusion in ASF works patch-3060.txt 2008-03-25 11:38 AM Amareshwari Sriramadasu 3 kB

Hadoop Flags: Incompatible change
Release Note:
The parameter boolean taskTrackerFirst is removed from org.apache.hadoop.mapred.MiniMRCluster constructors.
Thus signature of following APIs
  public MiniMRCluster(int jobTrackerPort, int taskTrackerPort, int numTaskTrackers, String namenode, boolean taskTrackerFirst, int numDir)
  public MiniMRCluster(int jobTrackerPort, int taskTrackerPort, int numTaskTrackers, String namenode, boolean taskTrackerFirst, int numDir, String[] racks)
  public MiniMRCluster(int jobTrackerPort, int taskTrackerPort, int numTaskTrackers, String namenode, boolean taskTrackerFirst, int numDir, String[] racks, String[] hosts)
  public MiniMRCluster(int jobTrackerPort, int taskTrackerPort, int numTaskTrackers, String namenode, boolean taskTrackerFirst, int numDir, String[] racks, String[] hosts, UnixUserGroupInformation ugi )
is changed to
  public MiniMRCluster(int jobTrackerPort, int taskTrackerPort, int numTaskTrackers, String namenode, int numDir)
  public MiniMRCluster(int jobTrackerPort, int taskTrackerPort, int numTaskTrackers, String namenode, int numDir, String[] racks)
  public MiniMRCluster(int jobTrackerPort, int taskTrackerPort, int numTaskTrackers, String namenode, int numDir, String[] racks, String[] hosts)
  public MiniMRCluster(int jobTrackerPort, int taskTrackerPort, int numTaskTrackers, String namenode, int numDir, String[] racks, String[] hosts, UnixUserGroupInformation ugi )
respectively.
Since the old signatures were not deprecated, any code using the old constructors must be changed to use the new constructors.
Resolution Date: 27/Mar/08 01:35 PM


 Description  « Hide
Looks like MiniMRCluster is ignoring the parameter taskTrackerFirst.
With current code, MiniMRCluster starts jobtracker first, and then starts tasktracker irrespective of taskTrackerFirst parameter.
Mapred either has to remove the parameter or provide taskTracker starting first functionality.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
[ Permlink | « Hide ]
Owen O'Malley added a comment - 20/Mar/08 06:33 PM
Go ahead and remove the task tracker first flag. Having port rolling is just too important for the reliability of the regression tests.

[ Permlink | « Hide ]
Amareshwari Sriramadasu added a comment - 25/Mar/08 11:38 AM
Here is a patch removing taskTrackerFirst flag

[ Permlink | « Hide ]
Hadoop QA added a comment - 25/Mar/08 06:49 PM
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12378559/patch-3060.txt
against trunk revision 619744.

@author +1. The patch does not contain any @author tags.

tests included +1. The patch appears to include 3 new or modified tests.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs -1. The patch appears to cause Findbugs to fail.

core tests -1. The patch failed core unit tests.

contrib tests -1. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2050/testReport/
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2050/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2050/console

This message is automatically generated.


[ Permlink | « Hide ]
Amareshwari Sriramadasu added a comment - 26/Mar/08 04:07 AM
Canceling the patch to address hudson failures.

[ Permlink | « Hide ]
Amareshwari Sriramadasu added a comment - 26/Mar/08 04:51 AM
Patch with hudson failure fixed.

[ Permlink | « Hide ]
Hadoop QA added a comment - 26/Mar/08 06:10 AM
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12378605/patch-3060.txt
against trunk revision 619744.

@author +1. The patch does not contain any @author tags.

tests included +1. The patch appears to include 6 new or modified tests.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests +1. The patch passed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2058/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2058/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2058/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2058/console

This message is automatically generated.


[ Permlink | « Hide ]
Devaraj Das added a comment - 27/Mar/08 01:35 PM
I just committed this. Thanks, Amareshwari!

[ Permlink | « Hide ]
Hudson added a comment - 28/Mar/08 12:17 PM
Integrated in Hadoop-trunk #444 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/444/)


Powered by a free Atlassian JIRA open source license for Apache Software Foundation. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.2-#335) - Bug/feature request - Atlassian news - Contact Administrators