String for configuring profiling should be customizable

• Key: HADOOP-2895
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Martin Traverso
• Reporter: Martin Traverso
• Affects Version/s: 0.16.0
• Fix Version/s: 0.17.0

Description

The choice of options that Hadoop uses may not be appropriate for all cases, so it would make sense to make this string configurable.

Comments

[Martin Traverso]

This patch adds a new property (mapred.task.profile.params) to configure the parameters that get passed to the child vm for when profiling is enabled.

[Hadoop QA]

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12376662/HADOOP-2895.patch
against trunk revision 619744.

@author +1. The patch does not contain any @author tags.

tests included +1. The patch appears to include 3 new or modified tests.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests +1. The patch passed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1858/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1858/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1858/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1858/console

This message is automatically generated.

[Chris Douglas]

The patch looks good. A minor nit: reordering/sorting the import stmts to match your preferences- and formatting changes in general- adds unnecessary noise and is best avoided unless the changes to the affected classes are dramatic. Would you mind regenerating your patch without those modifications? Otherwise, +1

[Martin Traverso]

Agreed. That was unintentional – apparently I had IDEA configured to optimize imports when generating patches.

Here's a new patch with only the necessary changes.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12376769/HADOOP-2895-2.patch
against trunk revision 619744.

@author +1. The patch does not contain any @author tags.

tests included +1. The patch appears to include 3 new or modified tests.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests -1. The patch failed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1868/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1868/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1868/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1868/console

This message is automatically generated.

[Chris Douglas]

I just committed this. Thanks, Martin!

[Hudson]

Integrated in Hadoop-trunk #416 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/416/)