A SequenceFile.Reader object is not closed properly in CopyFiles

• Key: HADOOP-2844
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Tsz Wo (Nicholas), SZE
• Reporter: Tsz Wo (Nicholas), SZE
• Component/s: util
• Fix Version/s: 0.17.0

Description

In CopyFiles line 186, the SequenceFile.Reader sl is never closed.

Comments

[Mahadev konar]

+1 .. reviewed.

[Tsz Wo (Nicholas), SZE]

This issue fixes the test problem reported in HADOOP-2813. Since this patch fixes a test problem, no additional test is included.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12375731/2844_20080215.patch
against trunk revision 619744.

@author +1. The patch does not contain any @author tags.

tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests +1. The patch passed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1809/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1809/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1809/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1809/console

This message is automatically generated.

[dhruba borthakur]

I just committed this. Thanks Nicholas!

[Hudson]

Integrated in Hadoop-trunk #405 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/405/)