[#HADOOP-2839] Remove deprecated methods in FileSystem

Hadoop Common

Remove deprecated methods in FileSystem

Created: 15/Feb/08 06:00 PM Updated: 21/May/08 08:05 PM

Return to search

Component/s:

Affects Version/s:

0.16.0

Fix Version/s:

0.17.0

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
HADOOP-2839-1.patch	2008-03-31 10:21 PM	Lohit Vijayarenu	11 kB
HADOOP-2839-2.patch	2008-04-02 09:05 AM	Lohit Vijayarenu	13 kB
HADOOP-2839-3.patch	2008-04-02 07:37 PM	Lohit Vijayarenu	13 kB

Issue Links:

Reference

This issue relates to:

HDFS-103 handle return value of globStatus() to be uniform.

Hadoop Flags:	Incompatible change, Reviewed
Release Note:	Removes deprecated API FileSystem#globPaths()
Resolution Date:	02/Apr/08 09:22 PM

Description

« Hide

Remove deprecated methods like listPath and globPath and fix all the use of these deprecated methods in FsShell.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Robert Chansler added a comment - 28/Mar/08 12:06 AM

If deprecated in 0.15, then remove for 0.17.
Otherwise set the fix version for this issue to 0.18.

[ Permlink | « Hide ]

Lohit Vijayarenu added a comment - 31/Mar/08 10:21 PM

listPaths was removed in ~~HADOOP-2563~~. This patch removes globPaths.

[ Permlink | « Hide ]

Hadoop QA added a comment - 01/Apr/08 08:41 AM

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12378985/HADOOP-2839-1.patch
against trunk revision 643282.

@author +1. The patch does not contain any @author tags.

tests included +1. The patch appears to include 3 new or modified tests.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests -1. The patch failed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2108/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2108/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2108/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2108/console

This message is automatically generated.

[ Permlink | « Hide ]

Lohit Vijayarenu added a comment - 01/Apr/08 08:55 AM

The test result say core test failed but does not say which test. When I look at console output I see that TestDistributedUpgrade failed, so I re-ran it and it seem to work on my machine. Retrying hudson. will investigate more on this failure

[ Permlink | « Hide ]

Mahadev konar added a comment - 01/Apr/08 05:22 PM

[ Permlink | « Hide ]

Hadoop QA added a comment - 01/Apr/08 07:34 PM

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12378985/HADOOP-2839-1.patch
against trunk revision 643282.

@author +1. The patch does not contain any @author tags.

tests included +1. The patch appears to include 3 new or modified tests.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests +1. The patch passed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2114/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2114/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2114/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2114/console

This message is automatically generated.

[ Permlink | « Hide ]

Lohit Vijayarenu added a comment - 01/Apr/08 07:52 PM

This run passed. I re-ran this test 5 times on my machine and does not seem to fail. The failure reported earlier was not related the changes in this patch as well.

[ Permlink | « Hide ]

Hadoop QA added a comment - 02/Apr/08 07:06 PM

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12379109/HADOOP-2839-2.patch
against trunk revision 643282.

@author +1. The patch does not contain any @author tags.

tests included +1. The patch appears to include 3 new or modified tests.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests -1. The patch failed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2125/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2125/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2125/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2125/console

This message is automatically generated.

[ Permlink | « Hide ]

Lohit Vijayarenu added a comment - 02/Apr/08 07:39 PM

globPaths() and globStatus() differ in their return values. globPaths() after deprecation never used to return null, while globStatus() does. To preserve the semantics I have added FileUtil.stat2Paths(FileStatus[], Path). I will open another JIRA to get rid of this function and fix all depended changes.