[#HADOOP-2832] bad code indentation in DFSClient

Hadoop Common

bad code indentation in DFSClient

Created: 14/Feb/08 07:47 PM Updated: 08/Jul/09 04:42 PM

Return to search

Component/s:

None

Affects Version/s:

None

Fix Version/s:

0.17.0

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
2832-1.patch	2008-02-14 10:51 PM	dhruba borthakur	5 kB
2832-1.patch	2008-02-14 10:50 PM	dhruba borthakur	5 kB
2832-1.patch	2008-02-14 10:45 PM	dhruba borthakur	5 kB
2832-1.patch	2008-02-14 09:41 PM	dhruba borthakur	5 kB
2832.patch	2008-02-14 07:49 PM	dhruba borthakur	5 kB

Resolution Date:

14/Feb/08 07:56 PM

Description

« Hide

A few lines of code in DFSClient are mis-indented because of the presence of tabs. The tabs should be removed.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

dhruba borthakur made changes - 14/Feb/08 07:48 PM

Field	Original Value	New Value
Assignee		dhruba borthakur [ dhruba ]

[ Permlink | « Hide ]

dhruba borthakur added a comment - 14/Feb/08 07:49 PM

Removed tabs.

dhruba borthakur made changes - 14/Feb/08 07:49 PM

Attachment

2832.patch [ 12375622 ]

Repository	Revision	Date	User	Message
ASF	#627860	Thu Feb 14 19:56:03 UTC 2008	dhruba	~~HADOOP-2832~~. Remove tabs from code of DFSClient for better indentation. (dhruba)
				Files Changed
				MODIFY /hadoop/core/trunk/src/java/org/apache/hadoop/dfs/DataNode.java MODIFY /hadoop/core/trunk/CHANGES.txt MODIFY /hadoop/core/trunk/src/java/org/apache/hadoop/dfs/DFSClient.java

dhruba borthakur made changes - 14/Feb/08 07:56 PM

Status

Open [ 1 ]

Patch Available [ 10002 ]

[ Permlink | « Hide ]

dhruba borthakur added a comment - 14/Feb/08 07:56 PM

I just committed this.

dhruba borthakur made changes - 14/Feb/08 07:56 PM

Resolution		Fixed [ 1 ]
Fix Version/s		0.17.0 [ 12312913 ]
Status	Patch Available [ 10002 ]	Resolved [ 5 ]

[ Permlink | « Hide ]

Tsz Wo (Nicholas), SZE added a comment - 14/Feb/08 07:56 PM

Thanks for fixing the indentation. Below are my comments:

the indentation still not correct in ResponseProcessor.run(), there are 4 spaces (instead of 2 spaces) after "try {".

could you also remove a un-used local variable "int numTargets = -1;"?

[ Permlink | « Hide ]

dhruba borthakur added a comment - 14/Feb/08 09:41 PM

Incorporated comments from Nicholas. Nicholas, can you pl review the new patch?

dhruba borthakur made changes - 14/Feb/08 09:41 PM

Attachment

2832-1.patch [ 12375631 ]

dhruba borthakur made changes - 14/Feb/08 10:45 PM

Attachment

2832-1.patch [ 12375638 ]

dhruba borthakur made changes - 14/Feb/08 10:50 PM

Attachment

2832-1.patch [ 12375639 ]

dhruba borthakur made changes - 14/Feb/08 10:51 PM

Attachment

2832-1.patch [ 12375640 ]

[ Permlink | « Hide ]

Tsz Wo (Nicholas), SZE added a comment - 14/Feb/08 10:56 PM

Repository	Revision	Date	User	Message
ASF	#627942	Fri Feb 15 04:40:15 UTC 2008	dhruba	~~HADOOP-2832~~. Remove tabs from code of DFSClient for better indentation. (dhruba)
				Files Changed
				MODIFY /hadoop/core/trunk/src/java/org/apache/hadoop/dfs/DFSClient.java

[ Permlink | « Hide ]

Hudson added a comment - 15/Feb/08 12:23 PM

Integrated in Hadoop-trunk #401 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/401/)

Nigel Daley made changes - 21/May/08 08:05 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

Owen O'Malley made changes - 08/Jul/09 04:42 PM

Component/s

dfs [ 12310710 ]