SimpleCharStream.getColumn(), getLine() methods to be removed.

• Key: HADOOP-2823
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Amareshwari Sriramadasu
• Reporter: Amareshwari Sriramadasu
• Component/s: record
• Fix Version/s: 0.17.0

Description

SimpleCharStream.getColumn(), getLine() methods need to be removed, as they are deprecated

Comments

[Amareshwari Sriramadasu]

Patch removes deprecated methods.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12378298/patch-2823.txt
against trunk revision 619744.

@author +1. The patch does not contain any @author tags.

tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests -1. The patch failed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2015/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2015/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2015/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2015/console

This message is automatically generated.

[Amareshwari Sriramadasu]

Test failure is due to time out. That is not related to the patch. All tests passed on my machine.

[Devaraj Das]

I just committed this. Thanks, Amareshwari!

[Hudson]

Integrated in Hadoop-trunk #440 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/440/)

[Robert Chansler]

Noted as incompatible in changes.txt

[Amareshwari Sriramadasu]

The deprecated methods in org.apache.hadoop.record.compiler.generated.SimpleCharStream :
public int getColumn()
and public int getLine() are removed