Remove deprecated Counters.getDisplayName(), getCounterNames(), getCounter(String counterName)

• Key: HADOOP-2818
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Amareshwari Sriramadasu
• Reporter: Amareshwari Sriramadasu
• Affects Version/s: 0.16.0
• Fix Version/s: 0.17.0

Description

Counters.getDisplayName(), getCounterNames(), getCounter(String counterName) need to removed as they are deprecated in 0.16.

Comments

[Amareshwari Sriramadasu]

I think we can undeprecate Counters.Group.getCounter(String counterName)), because, if we remove that method, even if we already know the counterName, there is no other way to get the counter value otherthan iterating again.
For ex. You may want to know the counter values in 3 groups simultaneously with a given counterName, all three groups have to be iterated if we remove this method.

[Amareshwari Sriramadasu]

Here is patch removing Counters.Group.getDisplayName(String counter) and Counters.Group.getCounterNames().

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12378617/patch-2818.txt
against trunk revision 619744.

@author +1. The patch does not contain any @author tags.

tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests +1. The patch passed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2060/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2060/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2060/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2060/console

This message is automatically generated.

[Amareshwari Sriramadasu]

This patch doesnt require a testcase as it removes deprecated methods.

[Tom White]

I've just committed this. Thanks Amareshwari!

[Robert Chansler]

Noted as incompatible in changes.txt