[#HADOOP-2799] Replace org.apache.hadoop.io.Closeable with java.io.Closeable

Hadoop Common

Replace org.apache.hadoop.io.Closeable with java.io.Closeable

Created: 07/Feb/08 11:40 PM Updated: 22/Aug/08 07:50 PM

Component/s:

Affects Version/s:

None

Fix Version/s:

0.18.0

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	2799_20080430.patch	2008-04-30 07:57 PM	Tsz Wo (Nicholas), SZE	0.8 kB

Hadoop Flags:	Reviewed
Resolution Date:	01/May/08 06:46 PM

Description

« Hide

Since java.io.Closeable is provided in Java 1.5, we should replace org.apache.hadoop.io.Closeable.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Tsz Wo (Nicholas), SZE added a comment - 30/Apr/08 07:57 PM

2799_20080430.patch: deprecate org.apache.hadoop.io.Closeable and make it extending java.io.Closeable.

[ Permlink | « Hide ]

Hadoop QA added a comment - 30/Apr/08 10:39 PM

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12381214/2799_20080430.patch
against trunk revision 645773.

@author +1. The patch does not contain any @author tags.

tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

javadoc +1. The javadoc tool did not generate any warning messages.

javac -1. The applied patch generated 458 javac compiler warnings (more than the trunk's current 452 warnings).

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs -1. The patch appears to introduce 1 new Findbugs warnings.

core tests +1. The patch passed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2355/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2355/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2355/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2355/console

This message is automatically generated.

[ Permlink | « Hide ]

Tsz Wo (Nicholas), SZE added a comment - 30/Apr/08 10:56 PM

The patch only deprecates the org.apache.hadoop.io.Closeable interface. So, no tests added.

The additional 6 javac warnings are due to "[deprecation] org.apache.hadoop.io.Closeable"

Findbugs warning says, "The class name org.apache.hadoop.io.Closeable shadows the simple name of implemented interface java.io.Closeable". This is something we are fixing here.

[ Permlink | « Hide ]

Chris Douglas added a comment - 01/May/08 06:46 PM

I just committed this. Thanks, Nicholas

[ Permlink | « Hide ]

Hudson added a comment - 02/May/08 11:42 PM

Integrated in Hadoop-trunk #477 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/477/)