[HADOOP-2790] TaskInProgress.hasSpeculativeTask is very inefficient

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.17.0
• Assignee: Owen O'Malley
• Reporter: Owen O'Malley
• Created: 07/Feb/08 02:51
• Updated: 08/Jul/09 16:52
• Resolved: 02/Mar/08 08:39

Description

Each call to JobInProgress.findNewTask can call TaskInProgress.hasSpeculativeTask once per a task. Each call to hasSpeculativeTask calls System.getCurrentTimeMillis, which can result in hundreds of thousands of calls to getCurrentTimeMillis. Additionally, it calls TaskInProgress.isOnlyCommitPending, which calls .values() on the map from task id to host name and iterates through them to see if any of the tasks are in commit pending. It would be better to have a commit pending boolean flag in the TaskInProgress. It also looks like there are other opportunities here, but those jumped out at me. We should also look at this method in the profiler.

Issue Links

• is related to: HADOOP-2119 JobTracker becomes non-responsive if the task trackers finish task too fast