dfs rm and rmr commands differ from POSIX standards

• Key: HADOOP-2193
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Mahadev konar
• Reporter: Mukund Madhugiri
• Affects Version/s: 0.15.1, 0.16.0
• Fix Version/s: 0.17.0

Description

Assuming the dfs commands follow POSIX standards, there are some problems with the DFS rm and rmr commands. I compared the DFS output with that of RHEL 4u5:

In both cases, if the file/directory does not exist, it will not give any indication to the user.

1. rm a file/directory that does not exist:
Linux: rm: cannot remove `testarea/two': No such file or directory
DFS: rm: /testarea/two

2. rmr a file/directory that does not exist:
Linux: rm: cannot remove `testarea/two': No such file or directory
DFS: rm: /testarea/two

Comments

[Lohit Vijayarenu]

Attached is a simple patch. Since fs.delete does not propagate FileNotFoundException, I have added a fs.exists() check even before we try to move to trash and attempt delete. updated testcase to verify this.

[Mahadev konar]

this patch fixes the issue.

with dfs -rm[-r] /nonexistentfile
this prints
cannot remove /nonexistentfile: No such file or directory.

the patch on a fs.delete returning false checks if the file does not exist. (this is just to save rpcs on a exists for every case) and then throws filenotfoundexcpetion.

[Lohit Vijayarenu]

+1 re-throwing FileNotFound seems better.

[Mahadev konar]

this patch removes some redundant code...

[Hadoop QA]

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12375281/hadoop_2193_1.patch
against trunk revision 619744.

@author +1. The patch does not contain any @author tags.

tests included +1. The patch appears to include 3 new or modified tests.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests +1. The patch passed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1777/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1777/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1777/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1777/console

This message is automatically generated.

[Mahadev konar]

removed tabs and empty spaces.

[Mahadev konar]

accidentally added a bracket in the last one

[Hadoop QA]

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12375300/hadoop_2193_4.patch
against trunk revision 619744.

@author +1. The patch does not contain any @author tags.

tests included +1. The patch appears to include 3 new or modified tests.

javadoc +1. The javadoc tool did not generate any warning messages.

javac +1. The applied patch does not generate any new javac compiler warnings.

release audit +1. The applied patch does not generate any new release audit warnings.

findbugs +1. The patch does not introduce any new Findbugs warnings.

core tests +1. The patch passed core unit tests.

contrib tests +1. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1780/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1780/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1780/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1780/console

This message is automatically generated.

[Raghu Angadi]

I just committed this. Thanks Mahadev.

[Hudson]

Integrated in Hadoop-trunk #398 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/398/)