[HADOOP-15831] Include modificationTime in the toString method of CopyListingFileStatus

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 08/Oct/18 20:33
• Updated: 12/Oct/18 10:23
• Resolved: 12/Oct/18 09:00

Description

I was looking at a DistCp error observed in hbase backup test:

2018-10-08 18:12:03,067 WARN  [Thread-933] mapred.LocalJobRunner$Job(590): job_local1175594345_0004
java.io.IOException: Inconsistent sequence file: current chunk file org.apache.hadoop.tools.CopyListingFileStatus@7ac56817{hdfs://localhost:41712/user/hbase/test-data/       c0f6352c-cf39-bbd1-7d10-57a9c01e7ce9/data/default/test-1539022262249/be1bf5445faddb63e45726410a07917a/f/f565f49046b04eecbf8d129eac7a7b88_SeqId_205_ length = 5100 aclEntries  = null, xAttrs = null} doesnt match prior entry org.apache.hadoop.tools.CopyListingFileStatus@7aa4deb2{hdfs://localhost:41712/user/hbase/test-data/c0f6352c-cf39-bbd1-7d10-   57a9c01e7ce9/data/default/test-1539022262249/be1bf5445faddb63e45726410a07917a/f/41b6cb64bae64cbcac47d1fd9aae59f4_SeqId_205_ length = 5142 aclEntries = null, xAttrs = null}
  at org.apache.hadoop.tools.mapred.CopyCommitter.concatFileChunks(CopyCommitter.java:276)
  at org.apache.hadoop.tools.mapred.CopyCommitter.commitJob(CopyCommitter.java:100)
  at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:567)
2018-10-08 18:12:03,150 INFO  [Time-limited test] mapreduce.MapReduceBackupCopyJob$BackupDistCp(226): Progress: 100.0% subTask: 1.0 mapProgress: 1.0

I noticed that modificationTime was not included in the toString of CopyListingFileStatus.

I propose including modificationTime so that it is easier to tell when the respective files last change.

Issue Links

• relates to: HBASE-21149 TestIncrementalBackupWithBulkLoad may fail due to file copy failure