[HADOOP-14519] Client$Connection#waitForWork may suffer from spurious wakeups

• Type: Bug
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.8.0
• Component/s: ipc
• Target Version/s: 3.5.0
• Assignee: John Zhuge
• Reporter: John Zhuge
• Created: 10/Jun/17 03:36
• Updated: 04/Jan/24 12:08

Description

Client$Connection#waitForWork may suffer spurious wakeup because the wait is not surrounded by a loop. See https://docs.oracle.com/javase/7/docs/api/java/lang/Object.html#wait().

Client$Connection#waitForWork

      if (calls.isEmpty() && !shouldCloseConnection.get() && running.get())  {
        long timeout = maxIdleTime-
              (Time.now()-lastActivity.get());
        if (timeout>0) {
          try {
            wait(timeout);                          <<<<<<==== spurious wakeup
          } catch (InterruptedException e) {}
        }
      }