[HADOOP-14135] Remove URI parameter in AWSCredentialProvider constructors

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.9.0, 3.0.0-alpha4, 2.8.2
• Component/s: fs/s3
• Target Version/s: 2.8.1, 3.0.0-alpha4
• Hadoop Flags: Reviewed
• Assignee: Mingliang Liu
• Reporter: Mingliang Liu
• Created: 28/Feb/17 22:49
• Updated: 02/Aug/17 12:32
• Resolved: 23/Mar/17 18:46

Description

This was from comment in HADOOP-13252.
It looks like the URI parameter is not needed for our AWSCredentialProvider constructors. This was useful because we relied on URI parameter for retrieving user:pass. Now in binding URIs, we have

279 S3xLoginHelper.Login creds = getAWSAccessKeys(binding, conf);
280	      credentials.add(new BasicAWSCredentialsProvider(
281	              creds.getUser(), creds.getPassword()));

This way, we only need configuration object (if necessary) for all AWSCredentialProvider implementations. The benefit is that, if we create AWSCredentialProvider list for DynamoDB, we don't have to pass down the associated file system URI. This might be useful to S3Guard tools.

Issue Links

• breaks: HADOOP-14507 extend per-bucket secret key config with explicit getPassword() on fs.s3a.$bucket.secret.key
• breaks: HADOOP-14723 reinstate URI parameter in AWSCredentialProvider constructors