[HADOOP-13720] Add more info to the msgs printed in AbstractDelegationTokenSecretManager for better supportability

• Type: Sub-task
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha2
• Component/s: common, security
• Labels: supportability
• Assignee: Yongjun Zhang
• Reporter: Yongjun Zhang
• Created: 13/Oct/16 21:34
• Updated: 06/Jun/17 22:43
• Resolved: 11/Nov/16 07:52

Description

Currently AbstractDelegationTokenSecretManager$checkToken does

  protected DelegationTokenInformation checkToken(TokenIdent identifier)
      throws InvalidToken {
    assert Thread.holdsLock(this);
    DelegationTokenInformation info = getTokenInfo(identifier);
    if (info == null) {
      throw new InvalidToken("token (" + identifier.toString()
          + ") can't be found in cache");
    }
    if (info.getRenewDate() < Time.now()) {
      throw new InvalidToken("token (" + identifier.toString() + ") is expired");
    }
    return info;
  } 

When a token is expried, we throw the above exception without printing out the info.getRenewDate() in the message. If we print it out, we could know for how long the token has not been renewed. This will help us investigate certain issues.

Create this jira as a request to add that part.

Issue Links

• breaks: HADOOP-13813 TestDelegationTokenFetcher#testDelegationTokenWithoutRenewer is failing
• breaks: HADOOP-13815 TestKMS#testDelegationTokensOpsSimple and TestKMS#testDelegationTokensOpsKerberized Fails in Trunk
• breaks: YARN-5875 TestTokenClientRMService#testTokenRenewalWrongUser fails
• breaks: YARN-5884 TestTokenClientRMService#testTokenRenewalWrongUser Fails after HADOOP-13720