[HADOOP-13279] Fix all Bad Practices

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.9.0
• Assignee: Yufei Gu
• Reporter: Yufei Gu
• Created: 15/Jun/16 21:52
• Updated: 17/Nov/16 20:56
• Resolved: 15/Jun/16 21:56

Description

The following code contain potential problems:

Unreleased Resource: Streams	TopCLI.java:738
Unreleased Resource: Streams	Graph.java:189
Unreleased Resource: Streams	CgroupsLCEResourcesHandler.java:291
Unreleased Resource: Streams	UnmanagedAMLauncher.java:195
Unreleased Resource: Streams	CGroupsHandlerImpl.java:319
Unreleased Resource: Streams	TrafficController.java:629
Portability Flaw: Locale Dependent Comparison	TimelineWebServices.java:421
Null Dereference	ApplicationImpl.java:465
Null Dereference	VisualizeStateMachine.java:52
Null Dereference	ContainerImpl.java:1089
Null Dereference	QueueManager.java:219
Null Dereference	QueueManager.java:232
Null Dereference	ResourceLocalizationService.java:1016
Null Dereference	ResourceLocalizationService.java:1023
Null Dereference	ResourceLocalizationService.java:1040
Null Dereference	ResourceLocalizationService.java:1052
Null Dereference	ProcfsBasedProcessTree.java:802
Null Dereference	TimelineClientImpl.java:639
Null Dereference	LocalizedResource.java:206
Code Correctness: Double-Checked Locking	ResourceHandlerModule.java:142
Code Correctness: Double-Checked Locking	RMPolicyProvider.java:51

Issue Links

• depends upon: YARN-5257 Fix unreleased resources and null dereferences