Issue Details (XML | Word | Printable)

Key: HADOOP-1266
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Hairong Kuang
Reporter: Konstantin Shvachko
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Hadoop Common

Remove DatanodeDescriptor dependency from NetworkTopology

Created: 17/Apr/07 11:11 PM   Updated: 08/Jul/09 04:42 PM
Return to search
Component/s: None
Affects Version/s: 0.14.1
Fix Version/s: 0.15.0

Time Tracking:
Not Specified

File Attachments:
  File Name Date Attached Attached By Size
Text File Licensed for inclusion in ASF works GenericTopology.patch 2007-09-06 11:25 PM Hairong Kuang 25 kB
Issue Links:
Blocker
 
dependent
 

Resolution Date: 10/Sep/07 06:47 PM


 Description  « Hide
NetworkTopology should operate only with the Node interface.
The actual class DatanodeDescriptor, which implements Node should not be used inside.
We should avoid introducing unnecessary dependencies.
This is the typical case when everything can and should be defined using the interface.
This becomes a requirement if we want to measure distances between other than data-nodes
types of nodes like TaskTrackers, clients.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Doug Cutting made changes - 08/May/07 07:43 PM
Field Original Value New Value
Fix Version/s 0.13.0 [ 12312348 ]
[ Permlink | « Hide ]
Arun C Murthy added a comment - 23/Aug/07 06:50 PM
+1, sounds like a good direction.

This is critical for getting map-reduce to be rack aware, specifically org.apache.hadoop.net.NetworkTopology.isOnSameRack. I need this for HADOOP-1721.


Arun C Murthy made changes - 23/Aug/07 06:51 PM
Link This issue blocks HADOOP-1721 [ HADOOP-1721 ]
Hairong Kuang made changes - 06/Sep/07 11:24 PM
Link This issue is depended upon by HADOOP-1652 [ HADOOP-1652 ]
[ Permlink | « Hide ]
Hairong Kuang added a comment - 06/Sep/07 11:25 PM
This patch removes the NetworkTopology's dependency on DatanodeDescriptor.

Hairong Kuang made changes - 06/Sep/07 11:25 PM
Attachment GenericTopology.patch [ 12365303 ]
[ Permlink | « Hide ]
dhruba borthakur added a comment - 07/Sep/07 06:26 PM
+1. Code looks good.

Hairong Kuang made changes - 07/Sep/07 10:17 PM
Fix Version/s 0.15.0 [ 12312565 ]
Affects Version/s 0.14.1 [ 12312694 ]
Status Open [ 1 ] Patch Available [ 10002 ]

Repository Revision Date User Message
ASF #574331 Mon Sep 10 18:46:43 UTC 2007 dhruba HADOOP-1266. Remove dependency of package org.apache.hadoop.net on
org.apache.hadoop.dfs. (Hairong Kuang via dhruba)
Files Changed
MODIFY /lucene/hadoop/trunk/src/test/org/apache/hadoop/dfs/TestReplicationPolicy.java
MODIFY /lucene/hadoop/trunk/src/java/org/apache/hadoop/net/NetworkTopology.java
MODIFY /lucene/hadoop/trunk/src/java/org/apache/hadoop/dfs/ReplicationTargetChooser.java
MODIFY /lucene/hadoop/trunk/src/java/org/apache/hadoop/dfs/DatanodeInfo.java
MODIFY /lucene/hadoop/trunk/src/java/org/apache/hadoop/net/NodeBase.java
MODIFY /lucene/hadoop/trunk/src/java/org/apache/hadoop/net/Node.java
MODIFY /lucene/hadoop/trunk/CHANGES.txt

[ Permlink | « Hide ]
dhruba borthakur added a comment - 10/Sep/07 06:47 PM
I just committed this. Thanks Hairong!

dhruba borthakur made changes - 10/Sep/07 06:47 PM
Status Patch Available [ 10002 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Doug Cutting made changes - 05/Nov/07 06:11 PM
Status Resolved [ 5 ] Closed [ 6 ]
Owen O'Malley made changes - 08/Jul/09 04:42 PM
Component/s dfs [ 12310710 ]

Powered by a free Atlassian JIRA open source license for Apache Software Foundation. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.2-#335) - Bug/feature request - Atlassian news - Contact Administrators