[HADOOP-11452] Make FileSystem.rename(path, path, options) public, specified, tested

• Type: Task
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.7.3
• Component/s: fs
• Labels: pull-request-available
• Target Version/s: 3.5.0
• Assignee: Steve Loughran
• Reporter: Yi Liu
• Created: 30/Dec/14 03:08
• Updated: 04/Jan/24 11:33

Description

Currently in FileSystem, rename with Rename options is protected and with deprecated annotation. And the default implementation is not atomic.

So this method is not able to be used outside. On the other hand, HDFS has a good and atomic implementation. (Also an interesting thing in DFSClient, the deprecated annotations for these two methods are opposite).

It makes sense to make public for rename with Rename options, since it's atomic for rename+overwrite, also it saves RPC calls if user desires rename+overwrite.

Issue Links

• contains: HADOOP-16255 ChecksumFS.Make FileSystem.rename(path, path, options) doesn't rename checksum
• is depended upon by: HADOOP-13846 S3A to implement rename(final Path src, final Path dst, final Rename... options)
• is duplicated by: HADOOP-13856 FileSystem.rename(final Path src, final Path dst, final Rename... options) to become public; specified, tested
• is related to: HADOOP-16281 ABFS: Rename operation, GetFileStatus before rename operation and throw exception on the driver side
• links to: GitHub Pull Request #743
• links to: GitHub Pull Request #2735