[HADOOP-11136] FTPInputStream should close wrapped stream

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: fs
• Assignee: Unassigned
• Reporter: Dzianis Sokal
• Created: 25/Sep/14 12:04
• Updated: 20/Jul/16 03:12

Description

This is reproducible in PASSIVE FTP mode, which is not supported by now(HADOOP-11135). However if we hack FTPFileSystem to enter into local passive mode, it will hang on client.completePendingCommand() in FTPInputStream line 114:

...
public synchronized void close() throws IOException {
...
boolean cmdCompleted = client.completePendingCommand();
...

Going to completePendingCommand() docs I see that the stream should be closed before calling it. So seems like stream should be closed

wrappedStream.close();

right before

boolean cmdCompleted = client.completePendingCommand();

Issue Links

• is blocked by: HADOOP-11135 Support PASSIVE mode in FTPFileSystem