[GIRAPH-576] BspServiceMaster.failureCleanup() shouldn't pass null in observers' applicationFailed() method

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.0.0
• Component/s: bsp
• Labels: easy newbie patch

Environment

Linux

• Assignee: Unassigned
• Reporter: Jess Garms
• Created: 20/Mar/13 17:56
• Updated: 21/Mar/13 20:35
• Resolved: 21/Mar/13 18:25

Description

failureCleanup() in BspServiceMaster gets called with a null exception from failJob(). That in turn passes a null exception to the set of MasterObservers, in their applicationFailed() method. They probably aren't expecting that. Instead we should pass an appropriate exception around depending on the cause of the failure.

I'll attach a patch.