[GERONIMO-3833] Hard-coded gbean names and versions in monitoring code

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1, 2.1.1, 2.2
• Fix Version/s: 2.1.1, 2.2
• Component/s: monitoring
• Security Level: public (Regular issues)
• Assignee: Viet Hung Nguyen
• Reporter: Jarek Gawor
• Created: 09/Feb/08 00:34
• Updated: 14/Mar/08 04:30
• Resolved: 14/Mar/08 04:30

Description

The monitoring code has hard-coded values in Java code and sql file:

1)

The ./plugins/monitoring/mconsole-war/src/main/java/org/apache/geronimo/monitoring/console/MRCConnector.java contains the following constant:

private static final String PATH = "geronimo:ServiceModule=org.apache.geronimo.plugins.monitoring/agent-car-jmx/2.1-SNAPSHOT/car,J2EEServer=geronimo,
name=MasterRemoteControlJMX,j2eeType=GBean";

2)

The ./plugins/monitoring/mconsole-ear/src/main/resources/MonitoringClientDB.sql contains a bunch of the following values:

'geronimo:J2EEServer=geronimo,ServiceModule=org.apache.geronimo.configs/tomcat6/2.1/car,j2eeType=GBean,name=TomcatWebConnector'

I'm not sure how these are used but in general these type of hardcoded values should be avoided. It's really hard to maintain and keep track of.