[GERONIMO-3003] Encrypt password strings in deployment plans

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Wish List
• Fix Version/s: 2.1.5, 2.2.1, 3.0.0
• Component/s: deployment
• Security Level: public (Regular issues)
• Assignee: Lin Quan Jiang
• Reporter: Aman Nanner
• Created: 21/Mar/07 20:07
• Updated: 02/Apr/10 01:34
• Resolved: 03/Mar/10 08:10

Description

Geronimo currently has a feature where password strings in the config.xml get encrypted using the org.apache.geronimo.util.EncryptionManager. This encryption is performed in the org.apache.geronimo.system.configuration.GBeanOverride class.

It would be desirable to have the same encryption applied to the password strings in deployment plans (e.g. datasource or JMS deployment plans within an EAR). Even though the plans are only used during the deployment process, and not at runtime, the plans are left with plaintext password strings sitting in them. It would be nice if the deployment process could internally encrypt the strings and then write back out the deployment plan to the file system. Also, this means that the deployment process will require the ability to decrypt strings that are already in encrypted format in the plan (in the case of redeployment, for example).

More discussion of this feature can be found in the following mailing list thread:

http://www.mail-archive.com/[e-mail]/msg05859.html

I would suggest that an appropriate spot to perform the encryption is in the org.apache.geronimo.j2ee.deployment.EARConfigBuilder class, perhaps in the following code just before the file is written to a temporary file:

---

if (gerModule.isSetAltDd()) {
// the the url of the alt dd
try

{ altVendorDDs.put(path, DeploymentUtil.toTempFile(earFile, gerModule.getAltDd().getStringValue())); }

catch (IOException e)

{ throw new DeploymentException("Invalid alt vendor dd url: " + gerModule.getAltDd().getStringValue(), e); }

---

However, somebody more familiar with the design might be able to suggest a better solution.