[GEODE-5382] Geode TransactionManagerImpl.commit() does not throw Exception when notifyAfterCompletion failed

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: transactions
• Assignee: Eric Shu
• Reporter: Eric Shu
• Created: 03/Jul/18 20:56
• Updated: 10/Jul/18 23:17

Description

Currently, commit() method only logs the exception.

    try {
      ((TransactionImpl) transactionImpl).notifyAfterCompletion(status = gtx.getStatus());
    } catch (Exception ge) {
      LogWriterI18n writer = TransactionUtils.getLogWriterI18n();
      if (writer.infoEnabled())
        writer.info(
            LocalizedStrings.TransactionManagerImpl_EXCEPTION_IN_NOTIFY_AFTER_COMPLETION_DUE_TO__0,
            ge.getMessage(), ge);
    }

It should throw exception to user application so that application can decide whether retry. Currently, data inconsistency could occur but applicate does not even notice about it.