Issue Details (XML | Word | Printable)

Key: FOR-811
Type: Sub-task Sub-task
Status: Reopened Reopened
Priority: Major Major
Assignee: Gavin
Reporter: David Crossley
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Forrest
FOR-808

shine and polish the pelt theme so that it closely resembles the pelt skin

Created: 08/Feb/06 01:47 PM   Updated: 13/May/09 03:50 AM
Return to search
Component/s: Plugin: internal.dispatcher, Skins (general issues)
Affects Version/s: None
Fix Version/s: None

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works pelt.fv.diff 2006-02-13 10:53 PM Gavin 7 kB
Text File Licensed for inclusion in ASF works pelt.screen.css.diff 2006-02-13 10:53 PM Gavin 13 kB
Text File Licensed for inclusion in ASF works siteinfo-credits.ft.diff 2006-02-13 10:53 PM Gavin 1 kB
Issue Links:
Blocker
Reference
 


 Description  « Hide
So that they can just switch from "pelt skin" to "pelt theme" and not get any surprises, e.g. "pelt skin' has no "xml doc" link.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Thorsten Scherler added a comment - 09/Feb/06 07:49 AM
Why not using the current pelt theme for this?

Just comment out the contacts that are not in the pelt skin.

David Crossley added a comment - 09/Feb/06 09:12 AM
Changed Summary to better describe the issue.

It doesn't need to exactly match, just no surprises for existing users. Where possible we will refine it to have better CSS and hooks.

David Crossley made changes - 09/Feb/06 09:12 AM
Field Original Value New Value
Summary need a theme that closely resembles the pelt skin shine and polish the pelt theme so that it closely resembles the pelt skin
Thorsten Scherler added a comment - 13/Feb/06 07:29 PM
We have to finish FOR-811 before investing time to solve this (FOR-816) issue.

More information http://marc.theaimsgroup.com/?l=forrest-dev&w=2&r=1&q=b&s=FOR-816

Thorsten Scherler made changes - 13/Feb/06 07:29 PM
Link This issue blocks FOR-816 [ FOR-816 ]
Gavin added a comment - 13/Feb/06 10:53 PM
3 Attatchments go a way towards addressing this issue. There are still some minor adjustments to make, however what has been done needs checking first. The CSS file pelt.basic.css has been done away with and any applicable CSS from it transferred into pelt.screen.css. Some changes were required also to pelt.fv and siteinfo-credits.fv.

Please check & Test, I have tested these files using a dispatcher enabled seed-sample site using forrest run.

Gavin made changes - 13/Feb/06 10:53 PM
Attachment pelt.screen.css.diff [ 12322921 ]
Attachment siteinfo-credits.ft.diff [ 12322922 ]
Attachment pelt.fv.diff [ 12322920 ]
David Crossley made changes - 14/Feb/06 06:09 AM
Other Info [Patch available]
Repository Revision Date User Message
ASF #381118 Sun Feb 26 16:34:38 UTC 2006 thorsten Applied patch for FOR-811 provided by Gavin. Thx Gavin. :) Further enhanced and polished the pelt theme. Please review.
Files Changed
MODIFY /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/html/siteinfo-credits.ft
MODIFY /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt.fv
MODIFY /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/css/pelt.screen.css

Thorsten Scherler made changes - 27/Feb/06 01:05 AM
Assignee Thorsten Scherler [ thorsten ]
Thorsten Scherler made changes - 27/Feb/06 01:05 AM
Status Open [ 1 ] In Progress [ 3 ]
Thorsten Scherler added a comment - 27/Feb/06 01:35 AM
Applied patch for FOR-811 provided by Gavin.

Thx Gavin. :)

Further enhanced and polished the pelt theme.

Please review.

Thorsten Scherler made changes - 27/Feb/06 01:35 AM
Status In Progress [ 3 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
David Crossley made changes - 28/Feb/06 07:33 AM
Status Resolved [ 5 ] Reopened [ 4 ]
Assignee Thorsten Scherler [ thorsten ]
Resolution Fixed [ 1 ]
Gavin added a comment - 15/Mar/06 09:34 PM
There is a width problem concerning the tables in IE6, they are too wide making the pages scrollable horizontally, it's fine in Firefox. There is a hack in the CSS already to cure this, but appears not to be working, I will investigate and then provide a patch.

This issue should then be closed so as to not hold up FOR-816 as I think everything else looks ok.

Thorsten Scherler added a comment - 01/May/06 06:37 AM
David changed status to reopen on the 27.02.06.

However the attached patches are applied.

David, what is missing to resolve this issue?

David Crossley added a comment - 01/May/06 07:04 AM
Well Gavin's previous comments said that patches were partially addressing the issues, so someone needs to check to see what else. Then there is the tables issue that he mentions. Also last time i looked there were some defaults that were different, e.g. IIRC two search boxes.

Repository Revision Date User Message
ASF #427240 Mon Jul 31 20:16:10 UTC 2006 thorsten FOR-811 shine and polish the pelt theme so that it closely resembles the pelt skin. Updating the theme profiler to have the same color style as the current forrest page.
Files Changed
MODIFY /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/common/css/branding-theme-profiler.ft

Repository Revision Date User Message
ASF #440288 Tue Sep 05 08:02:00 UTC 2006 crossley Synchronise colours to match the current pelt skin.
Fix a problem with colour of "header" and "container" that caused all pages
that had less content than the length of the left-hand menu to have a dark-blue
background.
Issue: FOR-811
Files Changed
MODIFY /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/common/css/branding-theme-profiler.ft
MODIFY /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt.fv
MODIFY /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/css/pelt.screen.css

Repository Revision Date User Message
ASF #514362 Sun Mar 04 06:21:50 UTC 2007 gmcdonald Changes to make pelt theme more like pelt skin FOR-811, a little more to do.
Files Changed
MODIFY /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/images/Thumbs.db
MODIFY /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/html/pelt-html.vt.xml
MODIFY /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/images/chapter.gif
MODIFY /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/css/pelt.screen.css
MODIFY /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/images/chapter_open.gif

Gavin added a comment - 04/Mar/07 06:40 AM
More enhancements committed, mainly the nav & tab menu font colors etc, added in an optional <div> area below the navigation.
The Table problem I described seems to have gone.

More to do, which I'll describe on list.

Gav...

Repository Revision Date User Message
ASF #514586 Mon Mar 05 07:31:24 UTC 2007 gmcdonald More enhancements to Pelt Theme, FOR-811. Fixing branding fontsize revealed CSS changes needed.
Files Changed
MODIFY /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/common/html/branding-fontsize.ft
MODIFY /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/html/pelt-html.vt.xml
MODIFY /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/css/pelt.screen.css

Gavin added a comment - 05/Mar/07 07:41 AM
Remove 'Patch Available' option, these have been applied.


Gavin made changes - 05/Mar/07 07:41 AM
Other Info [Patch available]
Repository Revision Date User Message
ASF #514623 Mon Mar 05 09:35:52 UTC 2007 gmcdonald More enhancements to Pelt Theme, FOR-811. Move white line into correct position, now it is visible
Files Changed
MODIFY /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/css/pelt.screen.css

Repository Revision Date User Message
ASF #521270 Thu Mar 22 13:52:40 UTC 2007 cdupoirieux Still shining the pelt theme.
FOR-811
Files Changed
MODIFY /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/css/pelt.basic.css
MODIFY /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt/css/pelt.screen.css

Gavin made changes - 23/Jun/07 09:18 AM
Link This issue is related to FOR-1001 [ FOR-1001 ]
Gavin added a comment - 23/Jun/07 09:20 AM
Last remaining Issue is that of subtabs not displaying correctly.
I think we need to expand the samples in each subtab to separate them.

Gavin made changes - 23/Jun/07 09:27 AM
Assignee Gavin [ ipv6guru ]
Gavin made changes - 13/May/09 03:45 AM
Link This issue is blocked by FOR-1165 [ FOR-1165 ]
Gavin made changes - 13/May/09 03:50 AM
Link This issue is blocked by FOR-1166 [ FOR-1166 ]