|
[
Permlink
| « Hide
]
Gavin added a comment - 12/Apr/06 09:18 PM
Not sure you need an .add file, but I did to then create the .diff
Added your patch for the initial Glossary, thanks. I needed to make some changes, so you might need to move your glossary.xml out of the way before doing 'svn update'. We use two-space indenting, not tabs, so i used Tidy to fix it. No content changes.
There were validation problems with glossary.xml file. These issues were noted as Todo items in the glossary plugin's status.xml file. I made a quick workaround to the glosarry DTD (see svn r393691) to enable multiple "see" and "definition" elements. Don't know if the xml needs better structure, e.g. <definitions><definition><definition> Regarding the patch for glossary-to-document.xsl ... Wouldn't it be better to use CSS rather than td@width? Anyway we should address that as a separate general issue. Will leave this issue open for a while in case there are more additions to the glossary, from you or other people. Thanks again. Thanks, patches applied. I will follow up separately regarding a few comments that will help with your patches.
BTW, please keep the issues separate, e.g. this FOR-639 should be about the site-author/contents/xdocs/glossary.xml file and we should have separate issues for each particular enhancement to the Glossary Plugin itself. The entries related to the Dispatcher need to move into the Dispatcher plugin docs.
I applied the latest patches (17/07/06) from Gavin. Thanks Gavin.
However the patches can be seen as setup of the infrastructure but are not resolving this issue. We still need content for the glossary documentation. Dispatcher will not leave the whiteboard till after 0.8
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||