Issue Details (XML | Word | Printable)

Key: FOR-559
Type: New Feature New Feature
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Ross Gardler
Reporter: Jeremias Maerki
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Forrest

FAQ+TOC problem: force-toc option

Created: 28/Jun/05 05:38 AM   Updated: 14/Feb/06 08:46 PM
Return to search
Component/s: Skins (general issues)
Affects Version/s: 0.6, 0.7, 0.8
Fix Version/s: 0.8

Time Tracking:
Not Specified

File Attachments:
  Size
File Licensed for inclusion in ASF works forrest-force-toc.diff 2005-06-28 05:39 AM Jeremias Maerki 4 kB

Other Info: Patch available


 Description  « Hide
This is a hybrid patch/RFE/bugfix. Today, I've taken another stab at the problem Clay Leeds reported to you in May:
http://www.mail-archive.com/user@forrest.apache.org/msg00528.html

We have the problem in FOP that the TOC for the FAQ page isn't generated.


 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Jeremias Maerki made changes - 28/Jun/05 05:39 AM
Field Original Value New Value
Attachment forrest-force-toc.diff [ 12310973 ]
David Crossley made changes - 24/Dec/05 11:21 AM
Description This is a hybrid patch/RFE/bugfix. Today, I've taken another stab at the problem Clay Leeds reported to you in May:
http://www.mail-archive.com/user@forrest.apache.org/msg00528.html

We have the problem in FOP that the TOC for the FAQ page isn't generated. I've found out what the problem is and have a suggestion for improvement. Essentially, the problem goes away when I change the skinconf.xml from:

  <toc max-depth="2" min-sections="3" location="page"/>

to:

  <toc max-depth="2" min-sections="1" location="page"/>

The reason for the whole problem is actually totally simple. The faq2document.xsl stylesheet creates exactly one top-level section. Due to the various checks in the stylesheet the TOC is suppressed when min-sections is set to anything higher than 1. That's the work-around I'm currently working with in FOP, but I think this can be improved. Setting min-sections to 3 or 4 is a very nice feature, but sometimes (like in the FAQ example), this is not ideal, so I implemented a forcing mechanism, I will attach as a patch. Using the meta tag in the document header is probably not the best idea but this let me add this feature without the need for a change in the DTD. I'll leave it up to you guys, what to do with this. It's just a suggestion and I've only patched the pelt skin so far. If this is nuts, just close the bug. :-) Thanks!
This is a hybrid patch/RFE/bugfix. Today, I've taken another stab at the problem Clay Leeds reported to you in May:
http://www.mail-archive.com/user@forrest.apache.org/msg00528.html

We have the problem in FOP that the TOC for the FAQ page isn't generated.
Other Info [Patch available]
Ross Gardler made changes - 14/Feb/06 08:46 PM
Status Open [ 1 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Assignee Ross Gardler [ rgardler ]
Fix Version/s 0.8-dev [ 12310040 ]