Issue Details (XML | Word | Printable)

Key: FOR-533
Type: Improvement Improvement
Status: Open Open
Priority: Minor Minor
Assignee: Unassigned
Reporter: Ross Gardler
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Forrest

Auto Generate plugins.xml entry

Created: 09/Jun/05 06:05 AM   Updated: 21/Nov/09 01:26 AM
Return to search
Component/s: Plugins (general issues)
Affects Version/s: None
Fix Version/s: 0.10

Time Tracking:
Not Specified

Issue Links:
Dependants
 
Duplicate
 
Incorporates
 

Urgency: Normal


 Description  « Hide
The information in the plugins.xml file would be better kept in the plugin directory and added to the plugins.xml file when deployed. This would reduce the amount of duplication in the plugins config files.

All the necessary values are now in the plugin build.xml file.

This change will require that the plugins.xml file be retrieved from the build directory rather than the plugins directory when building the plugin documentation pages. We will therefore need a fall back to retrieve this file from the network if it is not currently available - this can be done with the locationmap

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #189638 Wed Jun 08 21:05:40 UTC 2005 rgardler deploy versioned plugins (partial solution for FOR-528), also took the opportunity to add some properties to the plugin build file that will be needed for (FOR-533)
Files Changed
MODIFY /forrest/trunk/plugins/pluginTemplate/build.xml
MODIFY /forrest/trunk/plugins/org.apache.forrest.plugin.input.simplified-docbook/build.xml
MODIFY /forrest/trunk/plugins/build.xml

Ross Gardler made changes - 10/Jun/05 10:46 PM
Field Original Value New Value
Link This issue incorporates FOR-427 [ FOR-427 ]
Ross Gardler added a comment - 05/Aug/05 08:19 PM
There is no description to this issue and it is a duplicate of the subsequent FOR-533 issue. I suspect it was a glitch in the migration process or something like that.

Ross Gardler made changes - 05/Aug/05 08:19 PM
Link This issue duplicates FOR-532 [ FOR-532 ]
Ross Gardler made changes - 09/Dec/05 11:58 PM
Link This issue blocks FOR-343 [ FOR-343 ]
Ross Gardler made changes - 10/Dec/05 07:10 AM
Priority Minor [ 4 ] Critical [ 2 ]
Fix Version/s 0.8-dev [ 12310040 ]
Ross Gardler made changes - 14/Jan/06 12:59 AM
Urgency Normal
Fix Version/s 0.8-dev [ 12310040 ]
Ross Gardler added a comment - 04/Mar/06 08:04 AM
Plugins.xml is currently unversioned. This results in the published plugins index being incorrect for older releases of Forrest. For more info see mail thread http://marc.theaimsgroup.com/?l=forrest-dev&m=114140648619147&w=2

Repository Revision Date User Message
ASF #383293 Sun Mar 05 07:45:07 UTC 2006 crossley Refer to each plugin's build.xml to increment the version numbers etc.
Keep entries in plugins.xml manually sychronised until FOR-533 is fixed.
Files Changed
MODIFY /forrest/trunk/site-author/content/xdocs/docs_0_80/howto/howto-buildPlugin.xml

David Crossley added a comment - 24/Aug/06 12:35 AM
Some more discussion is now here:
 Re: Fixing FOR-533
 http://marc.theaimsgroup.com/?t=115625031300002
 

Ross Gardler added a comment - 11/Sep/06 09:23 AM
There is a problem with this approach (from the user mailing list):


>> when i type "forrest available-plugins" i can see the required version
>> for a plugin.
>> i'm running 0.7 version and there almost all plugins required 0.8
>> version. is taht really true?
>
>
> This appears to be a problem with the generation of the plugins index.
> It appears the 0.7 plugins index is showing the plugins for 0.8. We need
> to make it so that the index only includes plugin version up to the
> version number for the index being generated. That is, there should be
> no 0.8 versions appearing on the 0.7 index page.
>
> It appears that we missed this when creating the versioned pages.

I'm rushing again...

The above described problem is not the one I am describing, although they are related. The index page on the website suffers the same problem, i.e. 0.8 plugins appearing on the 0.7 index.

It looks like we need to keep a versioned copy of plugins.xml - attaching these comments the relevant JIRA issue.

David Crossley added a comment - 08/Nov/06 06:17 AM
Ross explained some of what needs to happen:
See http://marc.theaimsgroup.com/?l=forrest-dev&m=115628912024269

Repository Revision Date User Message
ASF #521010 Wed Mar 21 21:45:51 UTC 2007 rgardler Create plugins.xml directly from the build.xml files of individual plugins. Partial fix for FOR-533
Files Changed
ADD /forrest/trunk/main/webapp/resources/stylesheets/pluginBuildFiles-to-pluginDescriptor.xsl
MODIFY /forrest/trunk/main/webapp/sitemap.xmap
ADD /forrest/trunk/main/webapp/plugins.xmap

Ross Gardler added a comment - 21/Mar/07 10:34 PM
I've done some of the work, the plugins.xml file is now generated from the build.xml file of plugins in the core and whiteboard plugin directories. This means the documentation page are dynamically generated.

However, the plugin install system does not use this file. It can't because Forrest is not running while the plugins are being installed, although it could be since they are not actually mounted until the first request that uses them. I need to think and/or experiment around this a little. Longer term we will be using Ivy to resolve the plugins so I'm not sure if it is worth doing an interim hack.

The other thing that is not currently supported is user defined plugin directories.

Repository Revision Date User Message
ASF #521074 Thu Mar 22 01:31:23 UTC 2007 crossley Use original specific match to process only the "Plugins Index" and not also normal xdocs.
Fix the break caused by r521010 for URIs like pluginDocs/index.html and pluginDocs/plugins_0_80/usingPlugins.html
Part of FOR-533.
Files Changed
MODIFY /forrest/trunk/main/webapp/sitemap.xmap

Ross Gardler added a comment - 31/Mar/07 09:12 PM
This work has been halted and reverted (by way of commenting out the plugins.xml match in plugins.xmap) in order to allows a 0.8 release without plugin source code.

Moved the issue to 0.9 and reduced priority.

Ross Gardler made changes - 31/Mar/07 09:12 PM
Priority Critical [ 2 ] Minor [ 4 ]
Fix Version/s 0.9 [ 12310041 ]
Fix Version/s 0.8-dev [ 12310040 ]
Tim Williams made changes - 21/Nov/09 01:26 AM
Fix Version/s 0.9-dev [ 12310041 ]
Fix Version/s 0.10 [ 12310092 ]