[FLUME-3205] Remove unnecessary 'synchronized' in ResettableFileInputStream

• Type: Improvement
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.8.0
• Component/s: Sinks+Sources
• Assignee: guangxian.liao
• Reporter: guangxian.liao
• Created: 26/Dec/17 14:48
• Updated: 27/Dec/17 14:28

Description

I found no concurrent access to ResettableFileInputStream object in flume code.
Remove 'synchronized' will improve performance of SpoolDirectorySource.
Tested with a file of 200MB，with 'synchronized' it took 9 seconds to read the file.
Without 'synchronized' it took 7 seconds.

Issue Links

• links to: GitHub Pull Request #192